[Flang] Add multiline error message support to pass-plugin-not-found (NFC) #73601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madanial0
requested review from
kiranchandramohan,
DanielCChen,
kkwli and
klausler
|
@llvm/pr-subscribers-flang-driver Author: None (madanial0) ChangesThe error message above has multiple lines on AIX, adding Full diff: https://github.com/llvm/llvm-project/pull/73601.diff 1 Files Affected:
diff --git a/flang/test/Driver/pass-plugin-not-found.f90 b/flang/test/Driver/pass-plugin-not-found.f90
index 08dd29e5dab0683..fc1e690a0cc72bb 100644
--- a/flang/test/Driver/pass-plugin-not-found.f90
+++ b/flang/test/Driver/pass-plugin-not-found.f90
@@ -6,4 +6,4 @@
! RUN: not %flang_fc1 -emit-llvm -o /dev/null -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR
! The exact wording of the error message depends on the system dlerror.
-! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': {{.*}}: {{.*}}{{[Nn]}}o such file{{.*}}'
+! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': {{.*}}{{[[:space:]].*}}{{.*}}: {{.*}}{{[Nn]}}o such file{{.*}}'
|
banach-space
approved these changes
Nov 28, 2023
Not at the moment the goal is to eventually have one |
madanial0
force-pushed
the
pass-plugin-error
branch
from
d4ee455 to
4b6bdda
Compare
madanial0
force-pushed
the
pass-plugin-error
branch
from
4b6bdda to
277d581
Compare
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Dec 7, 2023
Local branch amd-gfx b8966b1 Merged main:770dc47659d4 into amd-gfx:8ac93c272270 Remote branch main 586986a [Flang] Add multiline error message support to pass-plugin-not-found (NFC) (llvm#73601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message above has multiple lines on AIX, adding
{{[[:space:]].*}}to match multiple lines