[PowerPC] Optimize BUILD_VECTOR from load and zeros #73609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzEq
changed the title
nemanjai
reviewed
Nov 28, 2023
| @@ -3437,6 +3437,12 @@ def : Pat<(store (i32 (extractelt v4i32:$A, 1)), ForceXForm:$src), | |||
| def : Pat<(store (f32 (extractelt v4f32:$A, 1)), ForceXForm:$src), | |||
| (STIWX (EXTRACT_SUBREG $A, sub_64), ForceXForm:$src)>; | |||
|
|
|||
| // BUILD_VECTOR via loads and zeros. | |||
| def : Pat<(v2f64 (build_vector (f64 (extloadf32 ForceXForm:$src)), (f64 fpimm0))), | |||
There was a problem hiding this comment.
Do we not have an opportunity to also improve the following:
- Non-extending load
- Single precision and i32 (other elements are zeros)
- Zero is at a different index
- Little endian
ecnelises
reviewed
Dec 6, 2023
| (v2i64 (COPY_TO_REGCLASS (LXSDX ForceXForm:$src), VSRC))>; | ||
| def : Pat<(v2i64 BVLoadAndZerosLong<0>.DAG), | ||
| (v2i64 (XXPERMDIs | ||
| (COPY_TO_REGCLASS (LXSDX ForceXForm:$src), VSRC), 2))>; |
There was a problem hiding this comment.
Can we use multiclass / defm to simplify the definitions?
There was a problem hiding this comment.
I've tried, however looks not simplified much(Maybe I was using a different approach than what's in your mind).
|
Ping. |
lei137
requested review from
stefanp-synopsys,
amykhuang,
diggerlin and
mandlebug
|
Take over this patch to get it through reviews and commited in #126599, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are encountered with patterns like
BUILD_VECTOR 0, 0, (load), 0resulted in suboptimal codegen. This PR improves it.