[KMSAN] Enable on PowerPC64 #73611
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| ; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s | ||
|
|
||
| target datalayout = "e-m:e-i64:64-n32:64" | ||
| target triple = "powerpc64le--linux" | ||
|
|
||
| define void @Store1(ptr %p, i8 %x) sanitize_memory { | ||
| entry: | ||
| store i8 %x, ptr %p | ||
| ret void | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Store1( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_store_1(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: store i8 {{.+}}, ptr [[SHADOW]] | ||
| ; CHECK: ret void | ||
|
|
||
| define void @Store2(ptr %p, i16 %x) sanitize_memory { | ||
| entry: | ||
| store i16 %x, ptr %p | ||
| ret void | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Store2( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_store_2(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: store i16 {{.+}}, ptr [[SHADOW]] | ||
| ; CHECK: ret void | ||
|
|
||
| define void @Store4(ptr %p, i32 %x) sanitize_memory { | ||
| entry: | ||
| store i32 %x, ptr %p | ||
| ret void | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Store4( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_store_4(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: store i32 {{.+}}, ptr [[SHADOW]] | ||
| ; CHECK: ret void | ||
|
|
||
| define void @Store8(ptr %p, i64 %x) sanitize_memory { | ||
| entry: | ||
| store i64 %x, ptr %p | ||
| ret void | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Store8( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_store_8(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: store i64 {{.+}}, ptr [[SHADOW]] | ||
| ; CHECK: ret void | ||
|
|
||
| define void @Store16(ptr %p, i128 %x) sanitize_memory { | ||
| entry: | ||
| store i128 %x, ptr %p | ||
| ret void | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Store16( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_store_n(ptr %p, i64 16) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: store i128 {{.+}}, ptr [[SHADOW]] | ||
| ; CHECK: ret void | ||
|
|
||
| define i8 @Load1(ptr %p) sanitize_memory { | ||
| entry: | ||
| %0 = load i8, ptr %p | ||
| ret i8 %0 | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Load1( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_load_1(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: [[SHADOW_VAL:%[a-z0-9_]+]] = load i8, ptr [[SHADOW]] | ||
| ; CHECK: [[ORIGIN_VAL:%[a-z0-9_]+]] = load i32, ptr [[ORIGIN]] | ||
| ; CHECK: store i8 [[SHADOW_VAL]], ptr %retval_shadow | ||
| ; CHECK: store i32 [[ORIGIN_VAL]], ptr %retval_origin | ||
| ; CHECK: ret i8 {{.+}} | ||
|
|
||
| define i16 @Load2(ptr %p) sanitize_memory { | ||
| entry: | ||
| %0 = load i16, ptr %p | ||
| ret i16 %0 | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Load2( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_load_2(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: [[SHADOW_VAL:%[a-z0-9_]+]] = load i16, ptr [[SHADOW]] | ||
| ; CHECK: [[ORIGIN_VAL:%[a-z0-9_]+]] = load i32, ptr [[ORIGIN]] | ||
| ; CHECK: store i16 [[SHADOW_VAL]], ptr %retval_shadow | ||
| ; CHECK: store i32 [[ORIGIN_VAL]], ptr %retval_origin | ||
| ; CHECK: ret i16 {{.+}} | ||
|
|
||
| define i32 @Load4(ptr %p) sanitize_memory { | ||
| entry: | ||
| %0 = load i32, ptr %p | ||
| ret i32 %0 | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Load4( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_load_4(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: [[SHADOW_VAL:%[a-z0-9_]+]] = load i32, ptr [[SHADOW]] | ||
| ; CHECK: [[ORIGIN_VAL:%[a-z0-9_]+]] = load i32, ptr [[ORIGIN]] | ||
| ; CHECK: store i32 [[SHADOW_VAL]], ptr %retval_shadow | ||
| ; CHECK: store i32 [[ORIGIN_VAL]], ptr %retval_origin | ||
| ; CHECK: ret i32 {{.+}} | ||
|
|
||
| define i64 @Load8(ptr %p) sanitize_memory { | ||
| entry: | ||
| %0 = load i64, ptr %p | ||
| ret i64 %0 | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Load8( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_load_8(ptr %p) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: [[SHADOW_VAL:%[a-z0-9_]+]] = load i64, ptr [[SHADOW]] | ||
| ; CHECK: [[ORIGIN_VAL:%[a-z0-9_]+]] = load i32, ptr [[ORIGIN]] | ||
| ; CHECK: store i64 [[SHADOW_VAL]], ptr %retval_shadow | ||
| ; CHECK: store i32 [[ORIGIN_VAL]], ptr %retval_origin | ||
| ; CHECK: ret i64 {{.+}} | ||
|
|
||
| define i128 @Load16(ptr %p) sanitize_memory { | ||
| entry: | ||
| %0 = load i128, ptr %p | ||
| ret i128 %0 | ||
| } | ||
|
|
||
| ; CHECK-LABEL: define {{[^@]+}}@Load16( | ||
| ; CHECK: [[META:%[a-z0-9_]+]] = call { ptr, ptr } @__msan_metadata_ptr_for_load_n(ptr %p, i64 16) | ||
| ; CHECK: [[SHADOW:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 0 | ||
| ; CHECK: [[ORIGIN:%[a-z0-9_]+]] = extractvalue { ptr, ptr } [[META]], 1 | ||
| ; CHECK: [[SHADOW_VAL:%[a-z0-9_]+]] = load i128, ptr [[SHADOW]] | ||
| ; CHECK: [[ORIGIN_VAL:%[a-z0-9_]+]] = load i32, ptr [[ORIGIN]] | ||
| ; CHECK: store i128 [[SHADOW_VAL]], ptr %retval_shadow | ||
| ; CHECK: store i32 [[ORIGIN_VAL]], ptr %retval_origin | ||
| ; CHECK: ret i128 {{.+}} | ||
|
There was a problem hiding this comment. Is is useful to add a vararg test? There was a problem hiding this comment. There is already a vararg tests in the same directory. The userspace and kernel vararg instrumentation is substantially similar so I didn't write a kernel specific test but I can if needed. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the directory name contains
PowerPC, it's unnecessary to repeatppc64le.You can use
basic-kernel.lllike SystemZ/ orkernel.ll.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other tests in the directory are named this way so I followed the convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llvm/test/Instrumentation/MemorySanitizer/PowerPC/vararg-ppc64.lldoes not follow the convention. I think the new test should follow other tests which follow the convention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. Would something like
kernel-64le.llwork since PowerPC encompasses both 32 and 64 bit and big and little endian?