Skip to content

Revert "[libc][bazel] Add copts to libc_support_library" #73723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

michaelrj-google
Copy link
Contributor

Reverts #73591

Broke downstream builds. I will look into relanding tomorrow.

@michaelrj-google michaelrj-google merged commit d6783c7 into main Nov 29, 2023
@michaelrj-google michaelrj-google deleted the revert-73591-libcBazelFixSupportLibrary branch November 29, 2023 00:21
@llvmbot llvmbot added the libc label Nov 29, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 29, 2023

@llvm/pr-subscribers-libc

Author: None (michaelrj-google)

Changes

Reverts llvm/llvm-project#73591

Broke downstream builds. I will look into relanding tomorrow.


Full diff: https://github.com/llvm/llvm-project/pull/73723.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl (+2-4)
diff --git a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
index 011f944311c281d..0c63bdb96333726 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
@@ -47,10 +47,8 @@ def _libc_library(name, hidden, copts = [], deps = [], **kwargs):
 # A convenience function which should be used to list all libc support libraries.
 # Any library which does not define a public function should be listed with
 # libc_support_library.
-def libc_support_library(name, copts = None, **kwargs):
-    copts = copts or []
-    copts = copts + ["-O3", "-fno-builtin", "-fno-lax-vector-conversions"]
-    _libc_library(name = name, copts = copts, hidden = False, **kwargs)
+def libc_support_library(name, **kwargs):
+    _libc_library(name = name, hidden = False, **kwargs)
 
 def libc_function(
         name,

Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Nov 30, 2023
Local branch amd-gfx 8de17e5 Merged main:1a041a3ad8a0 into amd-gfx:5e0dd61a0e31
Remote branch main d6783c7 Revert "[libc][bazel] Add copts to libc_support_library" (llvm#73723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants