[Fuchsia] Explicitly set C++ standard C++23 in libcxx tests #73760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Haowei (zeroomega) ChangesThis patch explicitly set C++23 in libcxx tests to avoid a test breakage caused by removal of codecvt. Full diff: https://github.com/llvm/llvm-project/pull/73760.diff 1 Files Affected:
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index 4b9085d99378c6f..57761ef194976bd 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -28,6 +28,7 @@ set(LLVM_STATIC_LINK_CXX_STDLIB ON CACHE BOOL "")
set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "")
set(LLDB_ENABLE_CURSES OFF CACHE BOOL "")
set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "")
+set(LIBCXX_TEST_PARAMS "std=c++23" CACHE STRING "")
if(WIN32)
set(FUCHSIA_DISABLE_DRIVER_BUILD ON)
|
|
We still need PR #73679 landed to clear build failures though. |
petrhosek
reviewed
Nov 29, 2023
This patch explicitly set C++23 in libcxx tests to avoid a test breakage caused by removal of codecvt.
zeroomega
force-pushed
the
libcxx-fix
branch
from
fc6f7de to
24f78f1
Compare
petrhosek
reviewed
Nov 29, 2023
| @@ -136,6 +136,7 @@ if(WIN32 OR LLVM_WINSYSROOT) | |||
| set(RUNTIMES_${target}_CMAKE_EXE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") | |||
| set(RUNTIMES_${target}_CMAKE_SHARED_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") | |||
| set(RUNTIMES_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") | |||
| set(RUNTIMES_${target}_LIBCXX_TEST_PARAMS "std=c++23" CACHE STRING "") | |||
There was a problem hiding this comment.
This is just a nit, but can you move this next to the other *_LIBCXX_* flags in this block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch explicitly set C++23 in libcxx tests to avoid a test breakage caused by removal of codecvt.