[AMDGPU] Preserve existing alias info on LDS DMA intrinsics in MIR #73870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now it is NFCI.
|
@llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) ChangesAs of now it is NFCI. Full diff: https://github.com/llvm/llvm-project/pull/73870.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 6d00cea80d7b24c..d6a768a64ff3421 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -9085,12 +9085,13 @@ SDValue SITargetLowering::LowerINTRINSIC_VOID(SDValue Op,
auto F = LoadMMO->getFlags() &
~(MachineMemOperand::MOStore | MachineMemOperand::MOLoad);
- LoadMMO = MF.getMachineMemOperand(LoadPtrI, F | MachineMemOperand::MOLoad,
- Size, LoadMMO->getBaseAlign());
+ LoadMMO =
+ MF.getMachineMemOperand(LoadPtrI, F | MachineMemOperand::MOLoad, Size,
+ LoadMMO->getBaseAlign(), LoadMMO->getAAInfo());
- MachineMemOperand *StoreMMO =
- MF.getMachineMemOperand(StorePtrI, F | MachineMemOperand::MOStore,
- sizeof(int32_t), LoadMMO->getBaseAlign());
+ MachineMemOperand *StoreMMO = MF.getMachineMemOperand(
+ StorePtrI, F | MachineMemOperand::MOStore, sizeof(int32_t),
+ LoadMMO->getBaseAlign(), LoadMMO->getAAInfo());
auto Load = DAG.getMachineNode(Opc, DL, M->getVTList(), Ops);
DAG.setNodeMemRefs(Load, {LoadMMO, StoreMMO});
@@ -9161,11 +9162,12 @@ SDValue SITargetLowering::LowerINTRINSIC_VOID(SDValue Op,
StorePtrI.AddrSpace = AMDGPUAS::LOCAL_ADDRESS;
auto F = LoadMMO->getFlags() &
~(MachineMemOperand::MOStore | MachineMemOperand::MOLoad);
- LoadMMO = MF.getMachineMemOperand(LoadPtrI, F | MachineMemOperand::MOLoad,
- Size, LoadMMO->getBaseAlign());
- MachineMemOperand *StoreMMO =
- MF.getMachineMemOperand(StorePtrI, F | MachineMemOperand::MOStore,
- sizeof(int32_t), Align(4));
+ LoadMMO =
+ MF.getMachineMemOperand(LoadPtrI, F | MachineMemOperand::MOLoad, Size,
+ LoadMMO->getBaseAlign(), LoadMMO->getAAInfo());
+ MachineMemOperand *StoreMMO = MF.getMachineMemOperand(
+ StorePtrI, F | MachineMemOperand::MOStore, sizeof(int32_t), Align(4),
+ LoadMMO->getAAInfo());
auto Load = DAG.getMachineNode(Opc, DL, Op->getVTList(), Ops);
DAG.setNodeMemRefs(Load, {LoadMMO, StoreMMO});
|
arsenm
approved these changes
Nov 30, 2023
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 6, 2024
…lvm#73870) As of now it is NFCI. Change-Id: I7707405037bd369223923e9eef7ace76fb53a17a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now it is NFCI.