[BOLT] CDSplit main logic part 1/2 #73895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShatianWang
force-pushed
the
112923GHCommit5AuxiVars
branch
from
f9b373d to
d1bc831
Compare
This diff defines and initializes auxiliary variables used by CDSplit and implements two important helper functions. The first helper function approximates the block level size increase if a function is hot-warm split at a given split index (X86 specific). The second helper function finds all calls in the form of X->Y or Y->X for each BF given function order [... X ... BF ... Y ...]. These calls are referred to as "cover calls". Their distance will decrease if BF's hot fragment size is further reduced by hot-warm splitting. NFC.
ShatianWang
force-pushed
the
112923GHCommit5AuxiVars
branch
from
d1bc831 to
3d4b26e
Compare
ShatianWang
changed the title
maksfb
reviewed
Nov 30, 2023
bolt/lib/Passes/SplitFunctions.cpp
Outdated
Comment on lines
209
to
211
| uint8_t BRANCH_SIZE = 0; | ||
| uint8_t LONG_UNCOND_BRANCH_SIZE_DELTA = 0; | ||
| uint8_t LONG_COND_BRANCH_SIZE_DELTA = 0; |
There was a problem hiding this comment.
Is there a reason for these variables to use a different naming scheme?
There was a problem hiding this comment.
I used capitalization because these variables are "constants" that depend on the architecture. I can change them to match the rest of the variable naming scheme if it is confusing.
There was a problem hiding this comment.
Let's use camel case to follow LLVM coding standards.
There was a problem hiding this comment.
Just made the changes in fixup! [BOLT] CDSplit main logic part 1/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff defines and initializes auxiliary variables used by CDSplit and implements two important helper functions. The first helper function approximates the block level size increase if a function is hot-warm split at a given split index (X86 specific). The second helper function finds all calls in the form of X->Y or Y->X for each BF given function order [... X ... BF ... Y ...]. These calls are referred to as "cover calls". Their distance will decrease if BF's hot fragment size is further reduced by hot-warm splitting. NFC.