[lldb] Remove pre GCC 4.8 workaround #73981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer awhile ago so garbage collect the pre 4.8 workaround. https://reviews.llvm.org/D66188
|
@llvm/pr-subscribers-lldb Author: Brad Smith (brad0) ChangesThe minimum GCC version was bumped up from 4.8 to 5.1 and then even newer https://reviews.llvm.org/D66188 Full diff: https://github.com/llvm/llvm-project/pull/73981.diff 1 Files Affected:
diff --git a/lldb/source/Host/common/Host.cpp b/lldb/source/Host/common/Host.cpp
index 49eac0b0fa7b0c6..8314d3581f6a47f 100644
--- a/lldb/source/Host/common/Host.cpp
+++ b/lldb/source/Host/common/Host.cpp
@@ -133,11 +133,7 @@ class ScopedPThreadCancelDisabler {
#endif // __linux__
#ifdef __linux__
-#if defined(__GNUC__) && (__GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 8))
-static __thread volatile sig_atomic_t g_usr1_called;
-#else
static thread_local volatile sig_atomic_t g_usr1_called;
-#endif
static void SigUsr1Handler(int) { g_usr1_called = 1; }
#endif // __linux__
|
bulbazord
approved these changes
Nov 30, 2023
It was 7.1, it is now 7.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer
awhile ago so garbage collect the pre 4.8 workaround.
https://reviews.llvm.org/D66188