Skip to content

[libc] Explicitly pin memory for the client symbol lookup #73988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[libc] Explicitly pin memory for the client symbol lookup #73988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions libc/utils/gpu/loader/amdgpu/Loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,18 +464,20 @@ int load(int argc, char **argv, char **envp, void *image, size_t size,
executable, rpc_client_symbol_name, &dev_agent, &rpc_client_sym))
handle_error(err);

void *rpc_client_host;
if (hsa_status_t err =
hsa_amd_memory_pool_allocate(coarsegrained_pool, sizeof(void *),
/*flags=*/0, &rpc_client_host))
handle_error(err);

void *rpc_client_dev;
if (hsa_status_t err = hsa_executable_symbol_get_info(
rpc_client_sym, HSA_EXECUTABLE_SYMBOL_INFO_VARIABLE_ADDRESS,
&rpc_client_dev))
handle_error(err);

// Pin some memory we can use to obtain the address of the rpc client.
void *rpc_client_storage = nullptr;
void *rpc_client_host = nullptr;
if (hsa_status_t err =
hsa_amd_memory_lock(&rpc_client_storage, sizeof(void *),
/*agents=*/nullptr, 0, &rpc_client_host))
handle_error(err);

// Copy the address of the client buffer from the device to the host.
if (hsa_status_t err = hsa_memcpy(rpc_client_host, host_agent, rpc_client_dev,
dev_agent, sizeof(void *)))
Expand All @@ -497,7 +499,7 @@ int load(int argc, char **argv, char **envp, void *image, size_t size,
if (hsa_status_t err = hsa_amd_memory_unlock(
const_cast<void *>(rpc_get_client_buffer(device_id))))
handle_error(err);
if (hsa_status_t err = hsa_amd_memory_pool_free(rpc_client_host))
if (hsa_status_t err = hsa_amd_memory_unlock(rpc_client_host))
handle_error(err);

// Obtain the GPU's fixed-frequency clock rate and copy it to the GPU.
Expand Down