Skip to content

MIRLangRef: fix llc invocation lines to write output #74104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

artagnon
Copy link
Contributor

@artagnon artagnon commented Dec 1, 2023

The first couple of llc invocations mentioned in the document are wrong, and users will get confused about no output being written. Fix them.

The first couple of llc invocations mentioned in the document are wrong,
and users will get confused about no output being written. Fix them.
@artagnon artagnon requested review from jayfoad, nikic and SLTozer December 1, 2023 16:48
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artagnon artagnon merged commit dabf849 into llvm:main Dec 8, 2023
@artagnon artagnon deleted the mir-langref branch December 8, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants