Skip to content

[OpenMP][NFC] Remove DelayedBinDesc #74360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions openmp/libomptarget/include/PluginManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,6 @@ struct PluginManager {
HostPtrToTableMapTy HostPtrToTableMap;
std::mutex TblMapMtx; ///< For HostPtrToTableMap

// Work around for plugins that call dlopen on shared libraries that call
// tgt_register_lib during their initialisation. Stash the pointers in a
// vector until the plugins are all initialised and then register them.
bool delayRegisterLib(__tgt_bin_desc *Desc) {
if (RTLsLoaded)
return false;
DelayedBinDesc.push_back(Desc);
return true;
}

void registerDelayedLibraries() {
// Only called by libomptarget constructor
RTLsLoaded = true;
for (auto *Desc : DelayedBinDesc)
__tgt_register_lib(Desc);
DelayedBinDesc.clear();
}

/// Return the number of usable devices.
int getNumDevices() { return getExclusiveDevicesAccessor()->size(); }

Expand Down Expand Up @@ -196,9 +178,6 @@ struct PluginManager {
void addRequirements(int64_t Flags) { Requirements.addRequirements(Flags); }

private:
bool RTLsLoaded = false;
llvm::SmallVector<__tgt_bin_desc *> DelayedBinDesc;

// List of all plugin adaptors, in use or not.
llvm::SmallVector<std::unique_ptr<PluginAdaptorTy>> PluginAdaptors;

Expand Down
3 changes: 0 additions & 3 deletions openmp/libomptarget/src/interface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ EXTERN void __tgt_register_requires(int64_t Flags) {
/// adds a target shared library to the target execution image
EXTERN void __tgt_register_lib(__tgt_bin_desc *Desc) {
TIMESCOPE();
if (PM->delayRegisterLib(Desc))
return;

PM->registerLib(Desc);
}

Expand Down
1 change: 0 additions & 1 deletion openmp/libomptarget/src/rtl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ __attribute__((constructor(101))) void init() {
PM->init();

Profiler::get();
PM->registerDelayedLibraries();
}

__attribute__((destructor(101))) void deinit() {
Expand Down
1 change: 1 addition & 0 deletions openmp/libomptarget/test/Inputs/empty.c
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

6 changes: 6 additions & 0 deletions openmp/libomptarget/test/offloading/bug60119.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// RUN: %clang-generic -fPIC -shared %S/../Inputs/empty.c -o %T/liba.so
// RUN: %clang-generic -fPIC -shared %S/../Inputs/empty.c -o %T/libb.so
// RUN: %clang-generic -rpath %T -L %T -l a -l b %s -o %t
// RUN: %t

int main() {}