[TextAPI] Add support to convert RecordSlices -> InterfaceFile #75007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
force-pushed
the
users/cyndyishida/TAPIStubifyp2
branch
from
d110ce3 to
0512593
Compare
Introduce RecordVisitor. This is used for different clients that want to extract information out of RecordSlice types. The first and immediate usecase is for serializing symbol information into TBD files.
cyndyishida
force-pushed
the
users/cyndyishida/TAPIStubifyp2
branch
from
0512593 to
87feac6
Compare
ributzka
reviewed
Dec 19, 2023
| @@ -14,6 +14,7 @@ | |||
| #ifndef LLVM_TEXTAPI_RECORD_H | |||
| #define LLVM_TEXTAPI_RECORD_H | |||
|
|
|||
| #include "llvm/ADT/MapVector.h" | |||
There was a problem hiding this comment.
Is this include needed in the header file?
There was a problem hiding this comment.
Yes, it was transitively included before in RecordSlice.h but is actually used in this file, so I moved it.
ributzka
approved these changes
Dec 19, 2023
cyndyishida
added a commit
to cyndyishida/llvm-project
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce RecordVisitor. This is used for different clients that want to extract information out of RecordSlice types.
The first and immediate use case is for serializing symbol information into TBD files.