Skip to content

[Dexter] Set ShouldBuild=false for Visual Studio solutions #75045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

SLTozer
Copy link
Contributor

@SLTozer SLTozer commented Dec 11, 2023

Since Dexter no longer intends to build any code, the ShouldBuild property in any Visual Studio project being run by Dexter should be false to ensure that a build step is never invoked by Dexter, whether the project has already been built or not.

Since Dexter no longer intends to build any code, the ShouldBuild property
in any Visual Studio project being run by Dexter should be false to ensure
that a build step is never invoked by Dexter, whether the project has
already been built or not.
@llvmbot
Copy link
Member

llvmbot commented Dec 11, 2023

@llvm/pr-subscribers-debuginfo

Author: Stephen Tozer (SLTozer)

Changes

Since Dexter no longer intends to build any code, the ShouldBuild property in any Visual Studio project being run by Dexter should be false to ensure that a build step is never invoked by Dexter, whether the project has already been built or not.


Full diff: https://github.com/llvm/llvm-project/pull/75045.diff

1 Files Affected:

  • (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py (+7)
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
index 50a97e2b77d15..0e20cfbbd264b 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
@@ -276,6 +276,13 @@ def launch(self, cmdline):
             project.Properties, "ActiveConfiguration"
         ).Object
         ActiveConfiguration.DebugSettings.CommandArguments = cmdline_str
+        ConfigurationName = ActiveConfiguration.ConfigurationName
+        SolConfig = self._fetch_property(
+            self._interface.Solution.SolutionBuild.SolutionConfigurations,
+            ConfigurationName,
+        )
+        for Context in SolConfig.SolutionContexts:
+            Context.ShouldBuild = False
 
         self.context.logger.note("Launching VS debugger...")
         self._fn_go(False)

Copy link
Contributor

@OCHyams OCHyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@SLTozer SLTozer merged commit e1c0e7e into llvm:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants