Skip to content

Add missing dep on MLIRToLLVMIRTranslationRegistration to mlir-opt. #75111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add missing dep on MLIRToLLVMIRTranslationRegistration to mlir-opt. #75111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mlir/tools/mlir-opt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ set(LIBS
MLIRTransformUtils
MLIRSupport
MLIRIR

# TODO: Remove when registerAllGPUToLLVMIRTranslations is no longer
# registered directly in mlir-opt.cpp.
MLIRToLLVMIRTranslationRegistration
)

# Exclude from libMLIR.so because this has static options intended for
Expand Down
4 changes: 4 additions & 0 deletions mlir/tools/mlir-opt/mlir-opt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,10 @@ int main(int argc, char **argv) {
DialectRegistry registry;
registerAllDialects(registry);
registerAllExtensions(registry);

// TODO: Remove this and the corresponding MLIRToLLVMIRTranslationRegistration
// cmake dependency when a safe dialect interface registration mechanism is
// implemented, see D157703 (and corresponding note on the declaration).
registerAllGPUToLLVMIRTranslations(registry);

#ifdef MLIR_INCLUDE_TESTS
Expand Down