[mlir] NamedAttribute utility generator #75118
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // RUN: mlir-opt %s -test-named-attrs -split-input-file --verify-diagnostics | FileCheck %s | ||
|
|
||
| func.func @f_unit_attr() attributes {test.test_unit} { // expected-remark {{found unit attr}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_unit_attr_fail() attributes {test.test_unit_fail} { // expected-error {{missing unit attr}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_int_attr() attributes {test.test_int = 42 : i32} { // expected-remark {{correct int value}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_int_attr_fail() attributes {test.test_int = 24 : i32} { // expected-error {{wrong int value}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_int_attr_fail2() attributes {test.test_int_fail = 42 : i64} { // expected-error {{missing int attr}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_lookup_attr() attributes {test.test_int = 42 : i64} { // expected-remark {{lookup found attr}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) // expected-remark {{lookup found attr}} | ||
| return // expected-remark {{lookup found attr}} | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_lookup_attr2() { // expected-error {{lookup failed}} | ||
| "test.any_attr_of_i32_str"() {attr = 3 : i32, test.test_int = 24 : i32} : () -> () // expected-remark {{lookup found attr}} | ||
| return // expected-error {{lookup failed}} | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @f_lookup_attr_fail() attributes {test.test_int_fail = 42 : i64} { // expected-error {{lookup failed}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) // expected-error {{lookup failed}} | ||
| return // expected-error {{lookup failed}} | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| // CHECK: func.func @f_set_attr() attributes {test.test_int = 42 : i32} | ||
| func.func @f_set_attr() { // expected-remark {{set int attr}} | ||
| %0:2 = "test.producer"() : () -> (i32, i32) | ||
| return | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| //===- TestNamedAttrs.cpp - Test passes for MLIR types | ||
| //-------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "TestAttributes.h" | ||
| #include "TestDialect.h" | ||
| #include "mlir/Pass/Pass.h" | ||
|
|
||
| using namespace mlir; | ||
| using namespace test; | ||
|
|
||
| namespace { | ||
| struct TestNamedAttrsPass | ||
| : public PassWrapper<TestNamedAttrsPass, OperationPass<func::FuncOp>> { | ||
| MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestNamedAttrsPass) | ||
|
|
||
| StringRef getArgument() const final { return "test-named-attrs"; } | ||
| StringRef getDescription() const final { | ||
| return "Test support for recursive types"; | ||
| } | ||
| void runOnOperation() override { | ||
| func::FuncOp func = getOperation(); | ||
|
|
||
| auto funcName = func.getName(); | ||
| // Just make sure recursive types are printed and parsed. | ||
| if (funcName.contains("f_unit_attr")) { | ||
| if (test::TestNamedUnitAttr::has(func)) { | ||
| func.emitRemark() << "found unit attr"; | ||
| } else { | ||
| func.emitOpError() << "missing unit attr"; | ||
| signalPassFailure(); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| if (funcName.contains("f_int_attr")) { | ||
| if (test::TestNamedIntAttr::has(func)) { | ||
| if (test::TestNamedIntAttr::getValue(func).getInt() == 42) { | ||
| func.emitRemark() << "correct int value"; | ||
| } else { | ||
| func.emitOpError() << "wrong int value"; | ||
| signalPassFailure(); | ||
| } | ||
| return; | ||
| } else { | ||
| func.emitOpError() << "missing int attr"; | ||
| signalPassFailure(); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| if (funcName.contains("f_lookup_attr")) { | ||
| func.walk([&](Operation *op) { | ||
| if (test::TestNamedIntAttr::lookupValue(op)) { | ||
| op->emitRemark() << "lookup found attr"; | ||
| } else { | ||
| op->emitOpError() << "lookup failed"; | ||
| signalPassFailure(); | ||
| } | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| if (funcName.contains("f_set_attr")) { | ||
| if (!test::TestNamedIntAttr::has(func)) { | ||
| auto intTy = IntegerType::get(func.getContext(), 32); | ||
| test::TestNamedIntAttr::setValue(func, IntegerAttr::get(intTy, 42)); | ||
| func.emitRemark() << "set int attr"; | ||
| } else { | ||
| func.emitOpError() << "attr already set"; | ||
| signalPassFailure(); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| // Unknown key. | ||
| func.emitOpError() << "unexpected function name"; | ||
| signalPassFailure(); | ||
| } | ||
| }; | ||
| } // namespace | ||
|
|
||
| namespace mlir { | ||
| namespace test { | ||
|
|
||
| void registerTestNamedAttrsPass() { PassRegistration<TestNamedAttrsPass>(); } | ||
|
|
||
| } // namespace test | ||
| } // namespace mlir |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "NamedAttribute" part isn't clear to me.
Also this is more than a "wrapper", it seems to me this is actually registering its own full fledge attribute?
I'm not sure I follow the definition, but I suspect this won't be uniqued with StringAttr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is no different than a StringAttr, so the usual interface works, but the new
getonly takes MLIRContext*. And once it is created, there is no way to get back to the wrapper class but it is mostly static lookup methods anyway.