Skip to content

[AMDGPU] Fix lack of LDS DMA check in the AA handling #75249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2023
Merged

[AMDGPU] Fix lack of LDS DMA check in the AA handling #75249

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82606c4
[AMDGPU] Fix lack of LDS DMA check in the AA handling
rampitec Dec 12, 2023
709ed50
Merge branch 'main' into lds-dma-disjoint-fix
rampitec Dec 13, 2023
d8d9f3a
Bail early in areMemAccessesTriviallyDisjoint
rampitec Dec 13, 2023
609be41
Remove old code
rampitec Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3651,6 +3651,9 @@ bool SIInstrInfo::areMemAccessesTriviallyDisjoint(const MachineInstr &MIa,
if (MIa.hasOrderedMemoryRef() || MIb.hasOrderedMemoryRef())
return false;

if (isLDSDMA(MIa) || isLDSDMA(MIb))
return false;

// TODO: Should we check the address space from the MachineMemOperand? That
// would allow us to distinguish objects we know don't alias based on the
// underlying address space, even if it was lowered to a different one,
Expand Down