[lldb] Fix buildbots after PR 74786

[clayborg]

Fix unexpected pass after #74786.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Greg Clayton (clayborg)

Changes

Fix unexpected pass after #74786.

---

Full diff: https://github.com/llvm/llvm-project/pull/75272.diff

1 Files Affected:

• (modified) lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py (+1-1)

diff --git a/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py b/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py
index 1988e997499b2..dff23da8662a0 100644
--- a/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py
+++ b/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py
@@ -42,7 +42,7 @@ def test_expr_union_static_members(self):
                 name="val", value="42"
             )])
 
-    @expectedFailureAll
+    @expectedFailureWindows
     def test_union_in_anon_namespace(self):
         """Tests that frame variable and expr work
            for union static data members in anonymous

[clayborg]

This test now passes after the new type lookup stuff went in due to improved lookups!

[clayborg]

Also fixed the SymbolFilePDBTests unit test code. I can't compile windows code, if anyone on windows can help try to build the SymbolFilePDBTests cmake target and then run the resulting binary to see if it passes that would really help. The perf win for this patch is quite high, so any help in getting this tested would really help out. The build must have the LLVM_ENABLE_DIA_SDK cmake variable set.

[Michael137]

Nice! lgtm

[DavidSpickett]

Going to merge this to fix the bots.

Our Windows bot does have the DIA SDK installed, but I don't know if it's being used. We'll see, if it breaks, I'll deal with it.