[CodeGen] Port StackProtector to new pass manager
#75334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
paperchalice
force-pushed
the
NPM/CodeGen/stack-protector
branch
2 times, most recently
from
2b10011 to
4b273ab
Compare
|
Ping @arsenm |
arsenm
reviewed
Dec 21, 2023
Comment on lines
112
to
118
| unsigned SSPBufferSize = SSPLayoutInfo::DefaultSSPBufferSize; | ||
|
|
||
| // A prologue is generated. | ||
| bool HasPrologue = false; | ||
|
|
||
| // IR checking code is generated. | ||
| bool HasIRCheck = false; |
There was a problem hiding this comment.
These fields look like they were moved to a new location, but not removed from the old one?
There was a problem hiding this comment.
Replace these fields with new a member SSPLayoutInfo Info; is OK, just to want to modify the old code as little as possible.
There was a problem hiding this comment.
I don't follow this. If you moved them the old references should be deleted? Changing less code isn't preferable to leaving dead code
There was a problem hiding this comment.
Merge them into one member LayoutInfo, but still need to keep the interface as an analysis pass.
paperchalice
force-pushed
the
NPM/CodeGen/stack-protector
branch
from
4b273ab to
af70d34
Compare
arsenm
approved these changes
Jan 9, 2024
paperchalice
force-pushed
the
NPM/CodeGen/stack-protector
branch
from
af70d34 to
f67aa75
Compare
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
The original `StackProtector` is both transform and analysis pass, break it into two passes now. `getAnalysis<StackProtector>()` could be now replaced by `FAM.getResult<SSPLayoutAnalysis>(F)` in new pass system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
StackProtectoris both transform and analysis pass, break it into two passes now.getAnalysis<StackProtector>()could be now replaced byFAM.getResult<SSPLayoutAnalysis>(F)in new pass system.