[flang][OpenMP] Avoid unnecessary init loop, use constructor instead,…

[kparzysz]

… NFC

SmallVector has a constructor that fills it with a number of copies of a given value. Use it instead of a loop that does the same thing.

[llvmbot]

@llvm/pr-subscribers-flang-fir-hlfir

@llvm/pr-subscribers-flang-openmp

Author: Krzysztof Parzyszek (kparzysz)

Changes

… NFC

SmallVector has a constructor that fills it with a number of copies of a given value. Use it instead of a loop that does the same thing.

---

Full diff: https://github.com/llvm/llvm-project/pull/75482.diff

1 Files Affected:

• (modified) flang/lib/Lower/OpenMP.cpp (+2-6)

diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index eeba87fcd1511..12b8ea82884d9 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -2117,12 +2117,8 @@ static void createBodyOfOp(
     for (const Fortran::semantics::Symbol *arg : args)
       loopVarTypeSize = std::max(loopVarTypeSize, arg->GetUltimate().size());
     mlir::Type loopVarType = getLoopVarType(converter, loopVarTypeSize);
-    llvm::SmallVector<mlir::Type> tiv;
-    llvm::SmallVector<mlir::Location> locs;
-    for (int i = 0; i < (int)args.size(); i++) {
-      tiv.push_back(loopVarType);
-      locs.push_back(loc);
-    }
+    llvm::SmallVector<mlir::Type> tiv(args.size(), loopVarType);
+    llvm::SmallVector<mlir::Location> locs(args.size(), loc);
     firOpBuilder.createBlock(&op.getRegion(), {}, tiv, locs);
     int argIndex = 0;
     // The argument is not currently in memory, so make a temporary for the

[skatrak]

LGTM!

[kiranchandramohan]

LG. Thanks for these cleanups.