-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[llvm-cov] format cells in code coverage report with 0/0 branches/functions/lines differently #75780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
efc86db
to
7a75dc6
Compare
I also needed to fix one test which was matching multiple rows in the table instead of one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is a good improvement for the UX!
I pre-approve with one nit.
I would like to wait for at least one more for the approval. @petrhosek , how is this?
✅ With the latest revision this PR passed the C/C++ code formatter. |
I'm sorry I didn't notice you already looked into it, and I added also sorting mechanism. Can you look at it too? |
DOWNGRADE1: <td class='column-entry-green'> | ||
DOWNGRADE1: 100.00% (3/3) | ||
DOWNGRADE1: <td class='column-entry-yellow'> | ||
DOWNGRADE1: 75.00% (9/12) | ||
DOWNGRADE1: <td class='column-entry-red'> | ||
DOWNGRADE1: 66.67% (4/6) | ||
DOWNGRADE1: <td class='column-entry-gray'> | ||
DOWNGRADE1: - (0/0) | ||
DOWNGRADE1: </tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously the red was actually the - (0/0), so I changed the threshold and make the test more precise
@hanickadot I hope we could land the 1st idea (when I approved) in advance. I expect sorting will be a good idea. (I also wish filtering) |
yes, already rewinded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Don't forget squashing.
…ifferenly (gray instead red) and make the table a bit nicer
…ifferenly (gray instead red) and make the table a bit nicer (#75780)
Pushed manually, 18e1179 |
Currently such cells in the report are formatted as red. Which screams "problem" but with more and more rangefied code, there can be whole files without any branch inside them.
Before:

After:

Things to notice:
- 0/0
coverage are no longer red