Skip to content

[test]Mark thinlto icp test as unsupported on powerpc #75979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mingmingl-llvm
Copy link
Contributor

@mingmingl-llvm mingmingl-llvm commented Dec 19, 2023

Test failed on ppc (https://lab.llvm.org/buildbot/#/builders/231/builds/18902), and logs shows missed import.

Cannot reproduce this with machines I could access so far. https://gcc.gnu.org/wiki/CompileFarm seems to provide ppc64 machine. Mark the thinlto icp test as unsupported for now.

@llvmbot llvmbot added compiler-rt PGO Profile Guided Optimizations llvm:transforms labels Dec 19, 2023
@llvmbot
Copy link
Member

llvmbot commented Dec 19, 2023

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-pgo

Author: Mingming Liu (minglotus-6)

Changes

Test failed on ppc (https://lab.llvm.org/buildbot/#/builders/231/builds/18902), and logs shows missed import.

Cannot reproduce this with machines I could access so far. https://gcc.gnu.org/wiki/CompileFarm seems to provide ppc machine. Mark the thinlto icp test as unsupported for now.


Full diff: https://github.com/llvm/llvm-project/pull/75979.diff

2 Files Affected:

  • (modified) compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp (+2)
  • (modified) llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll (+2)
diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index ed7faada0b8630..a8644bdb26ea64 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -35,6 +35,8 @@
 // specifies OS as Triple::OS::Win32
 //
 // UNSUPPORTED: target={{i.86.*windows.*}}
+// FIXME: Re-enable the test on powerpc.
+// UNSUPPORTED: powerpc-registered-target
 
 // RUN: rm -rf %t && split-file %s %t && cd %t
 
diff --git a/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll b/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
index d2f4696ccf41d7..8ed989a85b1ee9 100644
--- a/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
+++ b/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
@@ -9,6 +9,8 @@
 ; The raw profiles storesd compressed function names, so profile reader should
 ; be built with zlib support to decompress them.
 ; REQUIRES: zlib
+; FIXME: Re-enable the test on powerpc.
+; UNSUPPORTED: powerpc-registered-target
 
 ; RUN: rm -rf %t && split-file %s %t && cd %t
 

@mingmingl-llvm mingmingl-llvm merged commit 85525f8 into llvm:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt llvm:transforms PGO Profile Guided Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants