Skip to content

[OpenMP] Check for gtest when building libomptarget unit tests #76141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

EthanLuisMcDonough
Copy link
Member

This patch addresses an issue introduced in pull request #74398. CMake will attempt to re-build gtest if openmp is enabled as a project (as opposed to being enabled as a runtime). This patch adds a check that prevents this from happening.

@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Dec 21, 2023
@EthanLuisMcDonough EthanLuisMcDonough changed the title [OpenMP] Fix buildbot patch when openmp is enabled as project [OpenMP] Check for gtest when building libomptarget unit tests Dec 21, 2023
@EthanLuisMcDonough EthanLuisMcDonough merged commit cb3a893 into llvm:main Dec 21, 2023
Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@kwk
Copy link
Contributor

kwk commented Dec 22, 2023

@EthanLuisMcDonough can you please have a look at #76225 and check if that error is somehow related?

@EthanLuisMcDonough EthanLuisMcDonough deleted the plugin-test-patch branch December 22, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants