Skip to content

[BOLT] Don't split likely fallthrough in CDSplit #76164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ShatianWang
Copy link
Contributor

This diff speeds up CDSplit by not considering any hot-warm splitting point that could break a fall through branch from a basic block to its most likely successor.

This diff speeds up CDSplit by not considering any hot-warm
splitting point that could break a fall through branch from a
basic block to its most likely successor.
@ShatianWang ShatianWang marked this pull request as ready for review December 21, 2023 18:46
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other changes besides avoiding splitting a likely fallthrough but I'm neutral about including them.

Please retitle as "[BOLT] Don't split likely fallthrough in CDSplit"

@ShatianWang ShatianWang changed the title [BOLT] Speeding up CDSplit [BOLT] Don't split likely fallthrough in CDSplit Dec 21, 2023
@ShatianWang ShatianWang merged commit 1577483 into llvm:main Dec 21, 2023
@ShatianWang ShatianWang deleted the 122123UpstreamCDSplitSpeedUp branch December 21, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants