Skip to content

[InstCombine] Fold select (or/and (icmp eq/ne a, b), other_cond), a, b to select (other_cond), a, b #76203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[InstCombine] Fold select (or/and (icmp eq/ne a, b), other_cond), a, b to select (other_cond), a, b #76203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31ea022
[InstCombine][NFC] Precommit tests for PR75784
XChy Dec 21, 2023
a56467d
[InstCombine] Fold select of and/or(icmp, other_cond) to select of ot…
XChy Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/InstCombine/InstCombineInternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final
// into simplier select instruction using isImpliedCondition.
Instruction *foldAndOrOfSelectUsingImpliedCond(Value *Op, SelectInst &SI,
bool IsAnd);

Instruction *foldSelectOfAndOr(SelectInst &SI);
Instruction *hoistFNegAboveFMulFDiv(Value *FNegOp, Instruction &FMFSource);

public:
Expand Down
53 changes: 53 additions & 0 deletions llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2683,6 +2683,56 @@ Instruction *InstCombinerImpl::foldAndOrOfSelectUsingImpliedCond(Value *Op,
}
}

Instruction *InstCombinerImpl::foldSelectOfAndOr(SelectInst &SI) {
Value *CondVal = SI.getCondition();
Value *CondLHS, *CondRHS;
bool IsBitwise = !isa<SelectInst>(CondVal);
bool IsAnd;

if (match(CondVal, m_LogicalOr(m_Value(CondLHS), m_Value(CondRHS))))
IsAnd = false;
else if (match(CondVal, m_LogicalAnd(m_Value(CondLHS), m_Value(CondRHS))))
IsAnd = true;
else
return nullptr;

Value *TrueVal = SI.getTrueValue(), *FalseVal = SI.getFalseValue();

// %cmp = icmp eq i32 %a, %b
// %cond = or i1 %other_cond, %cmp
// %select = select i1 %cond, i32 %a, i32 %b
// =>
// %select = select i1 %other_cond, i32 %a, i32 %b

// Or for an inverted version, we fold it like:
// %cmp = icmp ne i32 %a, %b
// %cond = and i1 %other_cond, %cmp
// %select = select i1 %cond, i32 %a, i32 %b
// =>
// %select = select i1 %other_cond, i32 %a, i32 %b

auto FoldAndOrOfEquality = [&](Value *Cmp, Value *OtherCond,
bool NeedToFreeze) -> Instruction * {
ICmpInst::Predicate Pred;
if (!match(Cmp, m_c_ICmp(Pred, m_Specific(TrueVal), m_Specific(FalseVal))))
return nullptr;
if (Pred != (IsAnd ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ))
return nullptr;
if (NeedToFreeze)
OtherCond = Builder.CreateFreeze(OtherCond);
return SelectInst::Create(OtherCond, TrueVal, FalseVal);
};

// Order doesn't matter for bitwise and/or. We care about FreezeInst only when
// and/or is logical.
if (Instruction *Ret = FoldAndOrOfEquality(CondLHS, CondRHS, !IsBitwise))
return Ret;
if (Instruction *Ret = FoldAndOrOfEquality(CondRHS, CondLHS, false))
return Ret;

return nullptr;
}

// Canonicalize select with fcmp to fabs(). -0.0 makes this tricky. We need
// fast-math-flags (nsz) or fsub with +0.0 (not fneg) for this to work.
static Instruction *foldSelectWithFCmpToFabs(SelectInst &SI,
Expand Down Expand Up @@ -3409,6 +3459,9 @@ Instruction *InstCombinerImpl::visitSelectInst(SelectInst &SI) {
}
}

if (Instruction *I = foldSelectOfAndOr(SI))
return I;

auto *SIFPOp = dyn_cast<FPMathOperator>(&SI);

if (auto *FCmp = dyn_cast<FCmpInst>(CondVal)) {
Expand Down
230 changes: 206 additions & 24 deletions llvm/test/Transforms/InstCombine/select-and-or.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,9 +613,9 @@ define i1 @and_or2_wrong_operand(i1 %a, i1 %b, i1 %c, i1 %d) {

define i1 @and_or3(i1 %a, i1 %b, i32 %x, i32 %y) {
; CHECK-LABEL: @and_or3(
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[C]], i1 true, i1 [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select i1 [[B:%.*]], i1 [[TMP1]], i1 false
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i1 true, i1 [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select i1 [[B:%.*]], i1 [[TMP2]], i1 false
; CHECK-NEXT: ret i1 [[R]]
;
%c = icmp eq i32 %x, %y
Expand All @@ -626,9 +626,9 @@ define i1 @and_or3(i1 %a, i1 %b, i32 %x, i32 %y) {

define i1 @and_or3_commuted(i1 %a, i1 %b, i32 %x, i32 %y) {
; CHECK-LABEL: @and_or3_commuted(
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[C]], i1 true, i1 [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select i1 [[B:%.*]], i1 [[TMP1]], i1 false
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i1 true, i1 [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select i1 [[B:%.*]], i1 [[TMP2]], i1 false
; CHECK-NEXT: ret i1 [[R]]
;
%c = icmp eq i32 %x, %y
Expand Down Expand Up @@ -665,9 +665,9 @@ define i1 @and_or3_multiuse(i1 %a, i1 %b, i32 %x, i32 %y) {

define <2 x i1> @and_or3_vec(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @and_or3_vec(
; CHECK-NEXT: [[C:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select <2 x i1> [[C]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[B:%.*]], <2 x i1> [[TMP1]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[B:%.*]], <2 x i1> [[TMP2]], <2 x i1> zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%c = icmp eq <2 x i32> %x, %y
Expand All @@ -678,9 +678,9 @@ define <2 x i1> @and_or3_vec(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %

define <2 x i1> @and_or3_vec_commuted(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @and_or3_vec_commuted(
; CHECK-NEXT: [[C:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select <2 x i1> [[C]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[B:%.*]], <2 x i1> [[TMP1]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[A:%.*]]
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[B:%.*]], <2 x i1> [[TMP2]], <2 x i1> zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%c = icmp eq <2 x i32> %x, %y
Expand Down Expand Up @@ -877,9 +877,9 @@ entry:

define i1 @or_and3(i1 %a, i1 %b, i32 %x, i32 %y) {
; CHECK-LABEL: @or_and3(
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[C]], i1 [[B:%.*]], i1 false
; CHECK-NEXT: [[R:%.*]] = select i1 [[A:%.*]], i1 true, i1 [[TMP1]]
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i1 [[B:%.*]], i1 false
; CHECK-NEXT: [[R:%.*]] = select i1 [[A:%.*]], i1 true, i1 [[TMP2]]
; CHECK-NEXT: ret i1 [[R]]
;
%c = icmp eq i32 %x, %y
Expand All @@ -890,9 +890,9 @@ define i1 @or_and3(i1 %a, i1 %b, i32 %x, i32 %y) {

define i1 @or_and3_commuted(i1 %a, i1 %b, i32 %x, i32 %y) {
; CHECK-LABEL: @or_and3_commuted(
; CHECK-NEXT: [[C:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[C]], i1 [[B:%.*]], i1 false
; CHECK-NEXT: [[R:%.*]] = select i1 [[A:%.*]], i1 true, i1 [[TMP1]]
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i1 [[B:%.*]], i1 false
; CHECK-NEXT: [[R:%.*]] = select i1 [[A:%.*]], i1 true, i1 [[TMP2]]
; CHECK-NEXT: ret i1 [[R]]
;
%c = icmp eq i32 %x, %y
Expand Down Expand Up @@ -929,9 +929,9 @@ define i1 @or_and3_multiuse(i1 %a, i1 %b, i32 %x, i32 %y) {

define <2 x i1> @or_and3_vec(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @or_and3_vec(
; CHECK-NEXT: [[C:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select <2 x i1> [[C]], <2 x i1> [[B:%.*]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[A:%.*]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[TMP1]]
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i1> [[B:%.*]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[A:%.*]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[TMP2]]
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%c = icmp eq <2 x i32> %x, %y
Expand All @@ -942,9 +942,9 @@ define <2 x i1> @or_and3_vec(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %

define <2 x i1> @or_and3_vec_commuted(<2 x i1> %a, <2 x i1> %b, <2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @or_and3_vec_commuted(
; CHECK-NEXT: [[C:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP1:%.*]] = select <2 x i1> [[C]], <2 x i1> [[B:%.*]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[A:%.*]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[TMP1]]
; CHECK-NEXT: [[TMP1:%.*]] = icmp ne <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = select <2 x i1> [[TMP1]], <2 x i1> [[B:%.*]], <2 x i1> zeroinitializer
; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[A:%.*]], <2 x i1> <i1 true, i1 true>, <2 x i1> [[TMP2]]
; CHECK-NEXT: ret <2 x i1> [[R]]
;
%c = icmp eq <2 x i32> %x, %y
Expand All @@ -965,3 +965,185 @@ define i1 @or_and3_wrong_operand(i1 %a, i1 %b, i32 %x, i32 %y, i1 %d) {
%r = select i1 %cond, i1 %d, i1 %b
ret i1 %r
}

define i32 @or_eq_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @or_eq_a_b(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp eq i32 %a, %b
%cond = or i1 %other_cond, %cmp
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @and_ne_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @and_ne_a_b(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp ne i32 %a, %b
%cond = and i1 %other_cond, %cmp
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @or_eq_a_b_commuted(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @or_eq_a_b_commuted(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[B:%.*]], i32 [[A:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp eq i32 %a, %b
%cond = or i1 %other_cond, %cmp
%select = select i1 %cond, i32 %b, i32 %a
ret i32 %select
}

define i32 @and_ne_a_b_commuted(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @and_ne_a_b_commuted(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[B:%.*]], i32 [[A:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp ne i32 %a, %b
%cond = and i1 %other_cond, %cmp
%select = select i1 %cond, i32 %b, i32 %a
ret i32 %select
}

define i32 @or_eq_different_operands(i32 %a, i32 %b, i32 %c) {
; CHECK-LABEL: @or_eq_different_operands(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], [[C:%.*]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[CMP]], i32 [[A]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
entry:
%cmp = icmp eq i32 %a, %c
%cmp1 = icmp eq i32 %b, %a
%cond = or i1 %cmp, %cmp1
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @or_eq_a_b_multi_use(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @or_eq_a_b_multi_use(
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[COND:%.*]] = or i1 [[CMP]], [[OTHER_COND:%.*]]
; CHECK-NEXT: call void @use(i1 [[CMP]])
; CHECK-NEXT: call void @use(i1 [[COND]])
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND]], i32 [[A]], i32 [[B]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp eq i32 %a, %b
%cond = or i1 %other_cond, %cmp
call void @use(i1 %cmp)
call void @use(i1 %cond)
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select
}

define <2 x i32> @or_eq_a_b_vec(<2 x i1> %other_cond ,<2 x i32> %a, <2 x i32> %b) {
; CHECK-LABEL: @or_eq_a_b_vec(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SELECT:%.*]] = select <2 x i1> [[OTHER_COND:%.*]], <2 x i32> [[A:%.*]], <2 x i32> [[B:%.*]]
; CHECK-NEXT: ret <2 x i32> [[SELECT]]
;
entry:
%cmp = icmp eq <2 x i32> %a, %b
%cond = or <2 x i1> %other_cond, %cmp
%select = select <2 x i1> %cond, <2 x i32> %a, <2 x i32> %b
ret <2 x i32> %select
}

define i32 @or_slt_a_b_fail(i1 %other_cond ,i32 %a, i32 %b) {
; CHECK-LABEL: @or_slt_a_b_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[COND:%.*]] = or i1 [[CMP]], [[OTHER_COND:%.*]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[COND]], i32 [[A]], i32 [[B]]
; CHECK-NEXT: ret i32 [[SELECT]]
; CHECK: 0:
; CHECK-NEXT: ret i32 [[SELECT]]
;
entry:
%cmp = icmp slt i32 %a, %b
%cond = or i1 %other_cond, %cmp
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select ret i32 %select
}

define i32 @or_ne_a_b_fail(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @or_ne_a_b_fail(
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], [[B:%.*]]
; CHECK-NEXT: [[COND:%.*]] = or i1 [[CMP]], [[OTHER_COND:%.*]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[COND]], i32 [[A]], i32 [[B]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp ne i32 %a, %b
%cond = or i1 %other_cond, %cmp
%select = select i1 %cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @and_ne_different_operands_fail(i32 %a, i32 %b, i32 %c) {
; CHECK-LABEL: @and_ne_different_operands_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[A:%.*]], [[C:%.*]]
; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[B:%.*]], [[C]]
; CHECK-NEXT: [[COND:%.*]] = and i1 [[CMP]], [[CMP1]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[COND]], i32 [[B]], i32 [[A]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
entry:
%cmp = icmp ne i32 %a, %c
%cmp1 = icmp ne i32 %b, %c
%cond = and i1 %cmp, %cmp1
%select = select i1 %cond, i32 %b, i32 %a
ret i32 %select
}

define i32 @logical_or_eq_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @logical_or_eq_a_b(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp eq i32 %a, %b
%or.cond = select i1 %other_cond, i1 true, i1 %cmp
%select = select i1 %or.cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @logical_commuted_or_eq_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @logical_commuted_or_eq_a_b(
; CHECK-NEXT: [[TMP1:%.*]] = freeze i1 [[OTHER_COND:%.*]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[TMP1]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp eq i32 %a, %b
%or.cond = select i1 %cmp, i1 true, i1 %other_cond
%select = select i1 %or.cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @logical_and_ne_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @logical_and_ne_a_b(
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[OTHER_COND:%.*]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp ne i32 %a, %b
%or.cond = select i1 %other_cond, i1 %cmp, i1 false
%select = select i1 %or.cond, i32 %a, i32 %b
ret i32 %select
}

define i32 @logical_commuted_and_ne_a_b(i1 %other_cond, i32 %a, i32 %b) {
; CHECK-LABEL: @logical_commuted_and_ne_a_b(
; CHECK-NEXT: [[TMP1:%.*]] = freeze i1 [[OTHER_COND:%.*]]
; CHECK-NEXT: [[SELECT:%.*]] = select i1 [[TMP1]], i32 [[A:%.*]], i32 [[B:%.*]]
; CHECK-NEXT: ret i32 [[SELECT]]
;
%cmp = icmp ne i32 %a, %b
%or.cond = select i1 %cmp, i1 %other_cond, i1 false
%select = select i1 %or.cond, i32 %a, i32 %b
ret i32 %select
}
4 changes: 1 addition & 3 deletions llvm/test/Transforms/Reassociate/basictest.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,8 @@ define i32 @test14(i32 %X1, i32 %X2) {

define i32 @test15(i32 %X1, i32 %X2, i32 %X3) {
; CHECK-LABEL: @test15(
; CHECK-NEXT: [[A:%.*]] = icmp ne i32 [[X1:%.*]], 0
; CHECK-NEXT: [[B:%.*]] = icmp slt i32 [[X2:%.*]], [[X3:%.*]]
; CHECK-NEXT: [[C:%.*]] = and i1 [[A]], [[B]]
; CHECK-NEXT: [[D:%.*]] = select i1 [[C]], i32 [[X1]], i32 0
; CHECK-NEXT: [[D:%.*]] = select i1 [[B]], i32 [[X1:%.*]], i32 0
; CHECK-NEXT: ret i32 [[D]]
;
%A = icmp ne i32 %X1, 0
Expand Down