-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[lldb/win] Fix -Wmissing-field-initializers warnings after 54981bb75d374 #76255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-lldb Author: Nico Weber (nico) ChangesFull diff: https://github.com/llvm/llvm-project/pull/76255.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp b/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
index 5c4f80b97009a3..fee485b7599ca0 100644
--- a/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
@@ -29,7 +29,7 @@ using namespace lldb_private;
#reg, alt, 8, 0, eEncodingUint, eFormatHexUppercase, \
{dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, generic, \
LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
- nullptr, nullptr, \
+ nullptr, nullptr, nullptr, \
}
#define DEFINE_GPR_BIN(reg, alt) #reg, alt, 8, 0, eEncodingUint, eFormatBinary
@@ -37,14 +37,14 @@ using namespace lldb_private;
#reg, NULL, 16, 0, eEncodingUint, eFormatVectorOfUInt64, \
{dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, LLDB_INVALID_REGNUM, \
LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
- nullptr, nullptr
+ nullptr, nullptr, nullptr,
#define DEFINE_GPR_PSEUDO_32(reg) \
{ \
#reg, nullptr, 4, 0, eEncodingUint, eFormatHexUppercase, \
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
- nullptr, nullptr \
+ nullptr, nullptr, nullptr, \
}
#define DEFINE_GPR_PSEUDO_16(reg) \
@@ -52,7 +52,7 @@ using namespace lldb_private;
#reg, nullptr, 2, 0, eEncodingUint, eFormatHexUppercase, \
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
- nullptr, nullptr \
+ nullptr, nullptr, nullptr, \
}
#define DEFINE_GPR_PSEUDO_8(reg) \
@@ -60,7 +60,7 @@ using namespace lldb_private;
#reg, nullptr, 1, 0, eEncodingUint, eFormatHexUppercase, \
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
- nullptr, nullptr \
+ nullptr, nullptr, nullptr, \
}
namespace {
|
You can test this locally with the following command:git-clang-format --diff 04c473bea3e0f135432698fcaafab52e1fe1b5ec 7bd8eade99bbf2408a35462f1f4f643d9649efb3 -- lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp View the diff from clang-format here.diff --git a/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp b/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
index fee485b759..3d32a3d58c 100644
--- a/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
@@ -25,43 +25,43 @@ using namespace lldb;
using namespace lldb_private;
#define DEFINE_GPR(reg, alt, generic) \
-{ \
- #reg, alt, 8, 0, eEncodingUint, eFormatHexUppercase, \
- {dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, generic, \
- LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
+ { \
+ #reg, alt, 8, 0, eEncodingUint, eFormatHexUppercase, \
+ {dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, generic, \
+ LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
nullptr, nullptr, nullptr, \
-}
+ }
#define DEFINE_GPR_BIN(reg, alt) #reg, alt, 8, 0, eEncodingUint, eFormatBinary
#define DEFINE_FPU_XMM(reg) \
#reg, NULL, 16, 0, eEncodingUint, eFormatVectorOfUInt64, \
- {dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
- nullptr, nullptr, nullptr,
+ {dwarf_##reg##_x86_64, dwarf_##reg##_x86_64, LLDB_INVALID_REGNUM, \
+ LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
+ nullptr, nullptr, nullptr,
#define DEFINE_GPR_PSEUDO_32(reg) \
-{ \
- #reg, nullptr, 4, 0, eEncodingUint, eFormatHexUppercase, \
- {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
+ { \
+ #reg, nullptr, 4, 0, eEncodingUint, eFormatHexUppercase, \
+ {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
+ LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
nullptr, nullptr, nullptr, \
-}
+ }
#define DEFINE_GPR_PSEUDO_16(reg) \
-{ \
- #reg, nullptr, 2, 0, eEncodingUint, eFormatHexUppercase, \
- {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
+ { \
+ #reg, nullptr, 2, 0, eEncodingUint, eFormatHexUppercase, \
+ {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
+ LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
nullptr, nullptr, nullptr, \
-}
+ }
#define DEFINE_GPR_PSEUDO_8(reg) \
-{ \
- #reg, nullptr, 1, 0, eEncodingUint, eFormatHexUppercase, \
- {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
- LLDB_INVALID_REGNUM, lldb_##reg##_x86_64 }, \
+ { \
+ #reg, nullptr, 1, 0, eEncodingUint, eFormatHexUppercase, \
+ {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, \
+ LLDB_INVALID_REGNUM, lldb_##reg##_x86_64}, \
nullptr, nullptr, nullptr, \
-}
+ }
namespace {
|
Thanks for the fix! Ignoring clang-format as it would obscure the intent of the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.