Skip to content

[Doc] update the usage of opt with mem2reg pass in tutorial #76282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2023
Merged

[Doc] update the usage of opt with mem2reg pass in tutorial #76282

merged 1 commit into from
Dec 24, 2023

Conversation

youkaichao
Copy link
Member

The current command will raise an error:

The opt -passname syntax for the new pass manager is not supported, please use opt -passes=<pipeline> (or the -p alias for a more concise version).

So we should update the usage.

@youkaichao
Copy link
Member Author

For the code reviewer: I don’t have commit access, please land this patch for me. Thx!

@XChy XChy self-requested a review December 24, 2023 12:10
XChy
XChy approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@XChy XChy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XChy XChy merged commit eea2176 into llvm:main Dec 24, 2023
@youkaichao youkaichao deleted the patch-1 branch December 24, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XChy XChy XChy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @XChy