Skip to content

[libc++][format] Improves tests. #76291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void test(StringT expected, StringViewT fmt, bool arg, std::size_t offset) {
std::formatter<bool, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void test(StringT expected, StringViewT fmt, const CharT* a, std::size_t offset)
std::formatter<T, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void test(StringT expected, StringViewT fmt, ArgumentT arg, std::size_t offset)
std::formatter<ArgumentT, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct Tester {
std::formatter<Str, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename std::basic_string_view<CharT>::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

std::basic_string<CharT> result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void test(std::basic_string_view<CharT> fmt, ArithmeticT arg, std::basic_string<
std::formatter<ArithmeticT, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename std::basic_string_view<CharT>::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

std::basic_string<CharT> result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void test(std::string expected, std::string_view fmt, color arg, std::size_t off
std::formatter<color, char> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename std::string_view::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

std::string result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void test(StringT expected, StringViewT fmt, PointerT arg, std::size_t offset) {
std::formatter<PointerT, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void test(StringT expected, StringViewT fmt, ArithmeticT arg, std::size_t offset
std::formatter<ArithmeticT, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void test(StringT expected, StringViewT fmt, StringT a, std::size_t offset) {
std::formatter<T, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void test(StringT expected, StringViewT fmt, ArithmeticT arg, std::size_t offset
std::formatter<ArithmeticT, CharT> formatter;
static_assert(std::semiregular<decltype(formatter)>);

auto it = formatter.parse(parse_ctx);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
assert(it == fmt.end() - offset);

StringT result;
Expand Down