Skip to content

[ci] Set timeout for individual tests and report slowest tests #76300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Dec 23, 2023

There are builds like
https://buildkite.com/llvm-project/github-pull-requests/builds/24894

It looks like a deadlock in a test, but we can't see which one.
--timeout= will make lit kill and report such tests.

--time-tests produces nice report about slowest test, so we can tune
them over time.

The same build as above with new flags
https://buildkite.com/llvm-project/github-pull-requests/builds/24961

@vitalybuka vitalybuka requested a review from ldionne December 23, 2023 20:51
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.ci-set-timeout-for-individual-tests-and-report-slowest-tests to main December 23, 2023 23:36
Created using spr 1.3.4
@vitalybuka
Copy link
Collaborator Author

ping

1 similar comment
@vitalybuka
Copy link
Collaborator Author

ping

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was OOO until Jan 8th, sorry for the delay. This LGTM, we actually do the same thing for libc++ tests.

@vitalybuka vitalybuka merged commit 004ec8e into main Jan 10, 2024
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/ci-set-timeout-for-individual-tests-and-report-slowest-tests branch January 10, 2024 18:39
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
…76300)

There are builds like
https://buildkite.com/llvm-project/github-pull-requests/builds/24894

It looks like a deadlock in a test, but we can't see which one.
`--timeout=` will make lit kill and report such tests.

`--time-tests` produces nice report about slowest test, so we can tune
them over time.

The same build as above with new flags
https://buildkite.com/llvm-project/github-pull-requests/builds/24961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants