Skip to content

[lld][NFC] Revert commit ccec22b675195bf. #76398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

cjacek
Copy link
Contributor

@cjacek cjacek commented Dec 26, 2023

This reverts commit ccec22b (#75183). It's no longer needed with #76251.

@llvmbot
Copy link
Member

llvmbot commented Dec 26, 2023

@llvm/pr-subscribers-platform-windows

@llvm/pr-subscribers-lld

Author: Jacek Caban (cjacek)

Changes

This reverts commit ccec22b (#75183). It's no longer needed with #76251.


Full diff: https://github.com/llvm/llvm-project/pull/76398.diff

1 Files Affected:

  • (modified) lld/COFF/Writer.cpp (+1-1)
diff --git a/lld/COFF/Writer.cpp b/lld/COFF/Writer.cpp
index 2982165530c08f..2e34a6c5cfa2c0 100644
--- a/lld/COFF/Writer.cpp
+++ b/lld/COFF/Writer.cpp
@@ -560,7 +560,7 @@ void Writer::createECCodeMap() {
   codeMap.clear();
 
   std::optional<chpe_range_type> lastType;
-  Chunk *first = nullptr, *last = nullptr;
+  Chunk *first, *last;
 
   auto closeRange = [&]() {
     if (lastType) {

@cjacek cjacek merged commit dc5fb32 into llvm:main Dec 26, 2023
@cjacek cjacek deleted the lld-codemap-gcc branch December 26, 2023 17:17
@dwblaikie
Copy link
Collaborator

Thanks!

(in the future, if a patch isn't going to be pre-commit reviewed, please don't send a pull request for it - generally if a pull request has been sent, it's an indication that a patch needs pre-commit reviewed, and should not be committed until that review is completed - we want to avoid situations where people get the impression that silence is ~= approval)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants