-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc++][format] P2637R3: Member visit
(std::basic_format_arg
)
#76449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Zingam
merged 44 commits into
llvm:main
from
H-G-Hristov:hgh/libcxx/P2637R3-member-visit-format
Jan 21, 2024
Merged
Changes from 41 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e1ab389
[libc++][format] P2637R3: Member visit
Zingam 0764fb3
Implemented member methods + WIP tests
Zingam 7a70aa6
Added `visit` with return type test WIP
Zingam fbdd8ac
WIP: visit.return_type.pass
Zingam 91348f1
WIP: visit.return_type.pass
Zingam ebab5b6
Fixed formatting
Zingam 1b8e407
Fixed formatting
Zingam a6e6aaa
Restored: visit_format_arg.pass.cpp + docs upate
Zingam 9301ae0
Addressed comments
Zingam 7f7c0c1
Fixed tests
Zingam ede04db
Added missing test cases
Zingam 30ee407
Fixed implementation of `__int128/__uint128`
Zingam 94aa9c0
Fixed deprecation warning errors
Zingam 1ee4bde
Fixed get.pass.cpp test
Zingam eb0bc0b
Addressed comments
Zingam 6e85ab6
Restored original formatting
Zingam d7d8eef
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
Zingam 4eb32fd
Restored formatting: get.pass.cpp
Zingam 9308255
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
Zingam 8c95988
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
Zingam 0007da3
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov 274319f
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov 87b46db
Try to fix CI
Zingam 4e770de
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov b2200ef
Try to fix CI
Zingam 4d9b6f3
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov e46c448
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov 3ea7346
Fix AIX and ARM CI
Zingam 3d02036
Merge branch 'hgh/libcxx/P2637R3-member-visit-format' of https://gith…
Zingam cd99382
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov cfd5f65
Try to fix CI
Zingam fb1c24c
Addressed comments
Zingam ffc1020
Revert Feature Test Macro (FTM) uses
Zingam e5228fa
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov 6f7535e
Update libcxx/test/support/test_basic_format_arg.h
H-G-Hristov dd7f629
Added `TEST_HAS_EXPLICIT_THIS_PARAMETER` and `_LIBCPP_HAS_EXPLICIT_TH…
Zingam 7eac0af
Quick fix
Zingam ed2be27
Unsupport tests on *apple-clang*
Zingam fa467ec
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
Zingam 654afb9
Fixed formatting
Zingam e73184c
Fixed mistake
Zingam 152a22b
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
H-G-Hristov c4c0639
Addressed comments
Zingam d8f7657
Merge branch 'main' into hgh/libcxx/P2637R3-member-visit-format
Zingam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -984,6 +984,12 @@ typedef __char32_t char32_t; | |
# define _LIBCPP_DEPRECATED_IN_CXX23 | ||
# endif | ||
|
||
# if _LIBCPP_STD_VER >= 26 | ||
# define _LIBCPP_DEPRECATED_IN_CXX26 _LIBCPP_DEPRECATED | ||
# else | ||
# define _LIBCPP_DEPRECATED_IN_CXX26 | ||
# endif | ||
|
||
# if !defined(_LIBCPP_HAS_NO_CHAR8_T) | ||
# define _LIBCPP_DEPRECATED_WITH_CHAR8_T _LIBCPP_DEPRECATED | ||
# else | ||
|
@@ -1513,6 +1519,11 @@ __sanitizer_verify_double_ended_contiguous_container(const void*, const void*, c | |
# define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK | ||
# endif | ||
|
||
// Clang-18 has support for deducing this, but it does not set the FTM. | ||
#if defined(__cpp_explicit_this_parameter) || (defined(_LIBCPP_CLANG_VER ) &&_LIBCPP_CLANG_VER >= 1800) | ||
# define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER | ||
#endif | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make sure merging this patch does not duplicate this entry. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course! |
||
#endif // __cplusplus | ||
|
||
#endif // _LIBCPP___CONFIG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.