Skip to content

[GitHub] Fix minor typos in .github/workflows #76592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

linux4life798
Copy link
Contributor

Fix one spelling typo and remove second newline from end of files.

@llvmbot
Copy link
Member

llvmbot commented Dec 29, 2023

@llvm/pr-subscribers-github-workflow

Author: Craig Hesling (linux4life798)

Changes

Fix one spelling typo and remove second newline from end of files.


Full diff: https://github.com/llvm/llvm-project/pull/76592.diff

3 Files Affected:

  • (modified) .github/workflows/README.md (+1-1)
  • (modified) .github/workflows/docs.yml (-1)
  • (modified) .github/workflows/libcxx-build-and-test.yaml (-1)
diff --git a/.github/workflows/README.md b/.github/workflows/README.md
index 2781d9cc0e63d6..ce34d2337e9c5a 100644
--- a/.github/workflows/README.md
+++ b/.github/workflows/README.md
@@ -1 +1 @@
-Github action workflows should be stored in this directrory.
+Github action workflows should be stored in this directory.
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 9c695e714edd63..bf559964ff97b8 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -167,4 +167,3 @@ jobs:
         run: |
           cmake -B flang-build -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;mlir;flang" -DLLVM_ENABLE_SPHINX=ON -DSPHINX_WARNINGS_AS_ERRORS=OFF ./llvm
           TZ=UTC ninja -C flang-build docs-flang-html docs-flang-man
-
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 25e8c8c1ef21aa..3fd49541fd7cb2 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -207,4 +207,3 @@ jobs:
             **/CMakeError.log
             **/CMakeOutput.log
             **/crash_diagnostics/*
-  

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you find these issues by manual inspection or with some automated tooling?

I wouldn't mind having enforced linting/formatting on the Github actions yaml files to ensure consistent formatting, but not sure how necessary that is.

@linux4life798
Copy link
Contributor Author

linux4life798 commented Dec 30, 2023

Unfortunately, these were detected/corrected mostly through my VS Code settings and spelling extension.

@boomanaiden154 boomanaiden154 merged commit ee94e54 into llvm:main Jan 3, 2024
@linux4life798 linux4life798 deleted the fix-workflows-typos branch January 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants