[mlir] Consider mlir-linalg-ods-gen as a tablegen tool in build #76843
Conversation
|
@llvm/pr-subscribers-mlir-linalg @llvm/pr-subscribers-mlir Author: Michael Holman (MikeHolman) ChangesResolves #76813 This was inadvertently causing double linking of Support. Locally repro'd and confirmed that this fixes the build issue with failing configuration. Full diff: https://github.com/llvm/llvm-project/pull/76843.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt b/mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt
index 2b2024da6409ac..f698469ebf05bd 100644
--- a/mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt
+++ b/mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt
@@ -1,8 +1,3 @@
-set(LLVM_LINK_COMPONENTS
- Core
- Support
- )
-
set(LIBS
MLIRIR
MLIRSupport
|
MikeHolman
changed the title
…ild (llvm#75093)" This reverts commit a24c581.
MikeHolman
force-pushed
the
fixdylibbuild
branch
from
2ac619c to
94a8970
Compare
MikeHolman
force-pushed
the
fixdylibbuild
branch
from
94a8970 to
6af1846
Compare
There is a bit of an issue with how `mlir-linalg-ods-yaml-gen` is classified in the MLIR build. Due to it being a tool, it is excluded from the install when using `-DLLVM_BUILD_TOOLS=OFF`. However, it is a necessary component of the build, so it can cause build issues with users of the installed LLVM, and so I think it should not be excluded. It is a tablegen-like tool, so my solution is to reclassify it that way in the build.
MikeHolman
changed the title
|
@stellaraccident Would you mind taking another look at this? I have the change in my fork so kind of have been lazy about trying to get it checked in, but definitely would like to get this change in at some point. |
I don't follow: I understand this tool as a tool internal to Linalg development, when is it needed by a user? |
There is a bit of an issue with how mlir-linalg-ods-yaml-gen is classified in the MLIR build. Due to it being a tool, it is excluded from the install when using -DLLVM_BUILD_TOOLS=OFF. However, it is a necessary component of the build, so it can cause build issues with users of the installed LLVM, and so I think it should not be excluded.
It is a tablegen-like tool, so my solution is to reclassify it that way in the build.
This change resolves #76813, which was an issue in my first patch that was inadvertently causing double linking of Support.
I locally repro'd and confirmed that this fixes the build issue with failing configuration.