[BasicAA] Enable separate storage hints by default

[davidtgoldblatt]

As requested in #76770 (review)

A few months of experimentation in a large codebase did not reveal any significant build speed regressions, and b07bf16 speeds up hint lookup even further.

[llvmbot]

@llvm/pr-subscribers-llvm-analysis

Author: David Goldblatt (davidtgoldblatt)

Changes

As requested in #76770 (review)

A few months of experimentation in a large codebase did not reveal any significant build speed regressions, and b07bf16 speeds up hint lookup even further.

---

Full diff: https://github.com/llvm/llvm-project/pull/76864.diff

1 Files Affected:

• (modified) llvm/lib/Analysis/BasicAliasAnalysis.cpp (+1-1)

diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
index 4ad70931fd4cfd..97f60d28e49917 100644
--- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
@@ -69,7 +69,7 @@ static cl::opt<bool> EnableRecPhiAnalysis("basic-aa-recphi", cl::Hidden,
                                           cl::init(true));
 
 static cl::opt<bool> EnableSeparateStorageAnalysis("basic-aa-separate-storage",
-                                                   cl::Hidden, cl::init(false));
+                                                   cl::Hidden, cl::init(true));
 
 /// SearchLimitReached / SearchTimes shows how often the limit of
 /// to decompose GEPs is reached. It will affect the precision

[nikic]

LGTM

[davidtgoldblatt]

Woops -- merged before checks finished (on autopilot -- haven't used the github workflow in a while). Feels safe enough to leave as is for now, but sorry in advance to posterity if this ends up breaking something. Please feel free to revert if so.