Skip to content

[BOLT][NFC] Expose YAMLProfileWriter::convert function #76909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Jan 4, 2024

The function is to be used by YAML profile emission in BAT mode for
BinaryFunctions not covered by BAT tables (same as in original binary).

Test Plan: NFC

aaupov and others added 16 commits January 3, 2024 21:25
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems with this, but do we really need 8 commits? It clutters history. Can you merge in a single one?

@aaupov
Copy link
Contributor Author

aaupov commented Feb 19, 2024

These are artifacts of Stacked PR workflow that's endorsed by LLVM, sorry about that. They will all be squashed into one prior to committing to main.

@aaupov aaupov changed the base branch from users/aaupov/spr/main.boltnfc-expose-yamlprofilewriterconvert-function to main March 20, 2024 21:33
Created using spr 1.3.4
@aaupov aaupov merged commit 061b408 into main Mar 20, 2024
@aaupov aaupov deleted the users/aaupov/spr/boltnfc-expose-yamlprofilewriterconvert-function branch March 20, 2024 21:35
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
The function is to be used by YAML profile emission in BAT mode for
BinaryFunctions not covered by BAT tables (same as in original binary).

Test Plan: NFC

Reviewers: rafaelauler, ayermolo, dcci, maksfb

Reviewed By: dcci

Pull Request: llvm#76909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants