-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[GlobalISel][NFC]Delete the comments of XXLegalizerInfo #76918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GlobalISel][NFC]Delete the comments of XXLegalizerInfo #76918
Conversation
Update the LegalizerInfo comments of AArch64/AMD64/ARM/M68k/RISCV/x86, according the BPFLegalizerInfo.
@llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-backend-m68k Author: Ningning Shi(史宁宁) (shining1984) ChangesUpdate the LegalizerInfo comments of AArch64/AMD64/ARM/M68k/RISCV/x86, according the BPFLegalizerInfo. Full diff: https://github.com/llvm/llvm-project/pull/76918.diff 6 Files Affected:
diff --git a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.h b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.h
index e96ec6db3a1bc2..29ac64d8a90c94 100644
--- a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.h
+++ b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.h
@@ -23,7 +23,8 @@ namespace llvm {
class AArch64Subtarget;
-/// This class provides the information for the target register banks.
+/// This class provides the information for the AArch64 target legalizer for
+/// GlobalISel.
class AArch64LegalizerInfo : public LegalizerInfo {
public:
AArch64LegalizerInfo(const AArch64Subtarget &ST);
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
index 1fa064891a2d93..f30be891eba507 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
@@ -27,7 +27,8 @@ class MachineIRBuilder;
namespace AMDGPU {
struct ImageDimIntrinsicInfo;
}
-/// This class provides the information for the target register banks.
+/// This class provides the information for the AMDGPU target legalizer for
+/// GlobalISel.
class AMDGPULegalizerInfo final : public LegalizerInfo {
const GCNSubtarget &ST;
diff --git a/llvm/lib/Target/ARM/ARMLegalizerInfo.h b/llvm/lib/Target/ARM/ARMLegalizerInfo.h
index 3636cc6402b810..e59ea9c06c49cb 100644
--- a/llvm/lib/Target/ARM/ARMLegalizerInfo.h
+++ b/llvm/lib/Target/ARM/ARMLegalizerInfo.h
@@ -23,7 +23,8 @@ namespace llvm {
class ARMSubtarget;
-/// This class provides the information for the target register banks.
+/// This class provides the information for the ARM target legalizer for
+/// GlobalISel.
class ARMLegalizerInfo : public LegalizerInfo {
public:
ARMLegalizerInfo(const ARMSubtarget &ST);
diff --git a/llvm/lib/Target/M68k/GISel/M68kLegalizerInfo.h b/llvm/lib/Target/M68k/GISel/M68kLegalizerInfo.h
index a10401ed1a9a3e..bc7d2a53ae62cb 100644
--- a/llvm/lib/Target/M68k/GISel/M68kLegalizerInfo.h
+++ b/llvm/lib/Target/M68k/GISel/M68kLegalizerInfo.h
@@ -20,7 +20,8 @@ namespace llvm {
class M68kSubtarget;
-/// This struct provides the information for the target register banks.
+/// This class provides the information for the M68k target legalizer for
+/// GlobalISel.
struct M68kLegalizerInfo : public LegalizerInfo {
public:
M68kLegalizerInfo(const M68kSubtarget &ST);
diff --git a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
index 4335bd0cbbff0e..18a0e2b637a140 100644
--- a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
+++ b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
@@ -21,7 +21,8 @@ class GISelChangeObserver;
class MachineIRBuilder;
class RISCVSubtarget;
-/// This class provides the information for the target register banks.
+/// This class provides the information for the RISCV target legalizer for
+/// GlobalISel.
class RISCVLegalizerInfo : public LegalizerInfo {
const RISCVSubtarget &STI;
const unsigned XLen;
diff --git a/llvm/lib/Target/X86/GISel/X86LegalizerInfo.h b/llvm/lib/Target/X86/GISel/X86LegalizerInfo.h
index 1f69feceae2750..99258d0dc397a0 100644
--- a/llvm/lib/Target/X86/GISel/X86LegalizerInfo.h
+++ b/llvm/lib/Target/X86/GISel/X86LegalizerInfo.h
@@ -21,7 +21,8 @@ namespace llvm {
class X86Subtarget;
class X86TargetMachine;
-/// This class provides the information for the target register banks.
+/// This class provides the information for the X86 target legalizer for
+/// GlobalISel.
class X86LegalizerInfo : public LegalizerInfo {
private:
/// Keep a reference to the X86Subtarget around so that we can
|
@@ -23,7 +23,8 @@ namespace llvm { | |||
|
|||
class ARMSubtarget; | |||
|
|||
/// This class provides the information for the target register banks. | |||
/// This class provides the information for the ARM target legalizer for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just delete the comment from all the target implementations altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I delete them.
Delete the LegalizerInfo comments of AArch64/AMD64/ARM/M68k/RISCV/x86, they are copied from register banks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Delete the LegalizerInfo comments of AArch64/AMD64/ARM/M68k/RISCV/x86, they are copied from register bank.
Delete the LegalizerInfo comments of AArch64/AMD64/ARM/M68k/RISCV/x86, they are copied from register bank.