Skip to content

[LLD] [MinGW] Remove an unnecessary include of unistd.h. NFC. #76953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mstorsjo
Copy link
Member

@mstorsjo mstorsjo commented Jan 4, 2024

This was present since when the MinGW LLD frontend first was merged in 894dbbe, where it most probably was a leftover from earlier evolution of the patch.

This was present since when the MinGW LLD frontend first was
merged in 894dbbe, where it
most probably was a leftover from earlier evolution of the
patch.
@llvmbot
Copy link
Member

llvmbot commented Jan 4, 2024

@llvm/pr-subscribers-platform-windows

@llvm/pr-subscribers-lld

Author: Martin Storsjö (mstorsjo)

Changes

This was present since when the MinGW LLD frontend first was merged in 894dbbe, where it most probably was a leftover from earlier evolution of the patch.


Full diff: https://github.com/llvm/llvm-project/pull/76953.diff

1 Files Affected:

  • (modified) lld/MinGW/Driver.cpp (-4)
diff --git a/lld/MinGW/Driver.cpp b/lld/MinGW/Driver.cpp
index 94f0ae7993e62e..5ba1bf0e4b4e82 100644
--- a/lld/MinGW/Driver.cpp
+++ b/lld/MinGW/Driver.cpp
@@ -46,10 +46,6 @@
 #include "llvm/TargetParser/Triple.h"
 #include <optional>
 
-#if !defined(_MSC_VER) && !defined(__MINGW32__)
-#include <unistd.h>
-#endif
-
 using namespace lld;
 using namespace llvm::opt;
 using namespace llvm;

@mstorsjo mstorsjo merged commit 6af713a into llvm:main Jan 4, 2024
@mstorsjo mstorsjo deleted the lld-mingw-unistd branch January 4, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants