Skip to content

[MLIR][Presburger] Shift GeneratingFunction.h to includes #77114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

Abhinav271828
Copy link
Contributor

We shift the GeneratingFunction.h header file to the include/ directory and wrap it in a detail namespace.

@llvmbot
Copy link
Member

llvmbot commented Jan 5, 2024

@llvm/pr-subscribers-mlir-presburger

@llvm/pr-subscribers-mlir

Author: None (Abhinav271828)

Changes

We shift the GeneratingFunction.h header file to the include/ directory and wrap it in a detail namespace.


Full diff: https://github.com/llvm/llvm-project/pull/77114.diff

1 Files Affected:

  • (renamed) mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h (+2)
diff --git a/mlir/lib/Analysis/Presburger/GeneratingFunction.h b/mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h
similarity index 99%
rename from mlir/lib/Analysis/Presburger/GeneratingFunction.h
rename to mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h
index f7deba921ea51e..318f1a6429a6c0 100644
--- a/mlir/lib/Analysis/Presburger/GeneratingFunction.h
+++ b/mlir/include/mlir/Analysis/Presburger/GeneratingFunction.h
@@ -19,6 +19,7 @@
 
 namespace mlir {
 namespace presburger {
+namespace detail {
 
 // A parametric point is a vector, each of whose elements
 // is an affine function of n parameters. Each row
@@ -128,6 +129,7 @@ class GeneratingFunction {
   std::vector<std::vector<Point>> denominators;
 };
 
+} // namespace detail
 } // namespace presburger
 } // namespace mlir
 

Copy link

github-actions bot commented Jan 6, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@Abhinav271828 Abhinav271828 merged commit bd0dc35 into llvm:main Jan 6, 2024
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
We shift the GeneratingFunction.h header file to the include/ directory
and wrap it in a `detail` namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants