Skip to content

Changed Checks from TriviallyCopyable to TriviallyCopyConstructible #77194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jan 10, 2024
Merged

Changed Checks from TriviallyCopyable to TriviallyCopyConstructible #77194

merged 29 commits into from
Jan 10, 2024

Conversation

11happy
Copy link
Contributor

@11happy 11happy commented Jan 6, 2024

Overview:
This pull request fixes #47355 where in the Clang compiler's range-loop-analysis incorrectly checks for trivial copyability instead of trivial copy constructibility, leading to erroneous warnings.

Testing:

  • Tested the updated code.
  • Verified that other functionalities remain unaffected.
    Screenshot from 2024-01-01 19-50-20

Dependencies:

  • No dependencies on other pull requests.

References:

CC:

11happy added 28 commits January 1, 2024 19:53
@11happy
Changed Checks from TriviallyCopyable to TriviallyCopyConstructible
3c8dfcf 
Signed-off-by: 11happy <[email protected]>
@11happy
Added tests
57b50cb 
Signed-off-by: 11happy <[email protected]>
@11happy
implemented static non member
c346904 
Signed-off-by: 11happy <[email protected]>
@11happy
Committing local changes before revert
81daac9
@11happy
Revert "implemented static non member"
723b9fd 
This reverts commit c346904.
@11happy
Revert "Committing local changes before revert"
d3483b5 
This reverts commit 81daac9.
@11happy
Internal Static member
6c0936c 
Signed-off-by: 11happy <[email protected]>
@11happy
Internal static member
41cfb32 
Signed-off-by: 11happy <[email protected]>
@11happy
Formatted the code
a2b208c 
Signed-off-by: 11happy <[email protected]>
@11happy
IsCopyConstructible
c5847f7 
Signed-off-by: 11happy <[email protected]>
@11happy
Formatted the code
5a03096 
Signed-off-by: 11happy <[email protected]>
@11happy
Added Release notes
7a44b58 
Signed-off-by: 11happy <[email protected]>
@11happy
Minor Fix
7382376 
Signed-off-by: 11happy <[email protected]>
@11happy
Changed Checks from TriviallyCopyable to TriviallyCopyConstructible
658ea09 
Signed-off-by: 11happy <[email protected]>
@11happy
Added tests
31d1de1 
Signed-off-by: 11happy <[email protected]>
@11happy
implemented static non member
c917059 
Signed-off-by: 11happy <[email protected]>
@11happy
Committing local changes before revert
bd4b449
@11happy
Revert "implemented static non member"
a7ac895 
This reverts commit c346904.
@11happy
Revert "Committing local changes before revert"
51659f6 
This reverts commit 81daac9.
@11happy
Internal Static member
b841647 
Signed-off-by: 11happy <[email protected]>
@11happy
Internal static member
8c3f1e1 
Signed-off-by: 11happy <[email protected]>
@11happy
Formatted the code
50054da 
Signed-off-by: 11happy <[email protected]>
@11happy
IsCopyConstructible
cbf03e2 
Signed-off-by: 11happy <[email protected]>
@11happy
Formatted the code
158d239 
Signed-off-by: 11happy <[email protected]>
@11happy
Added Release notes
07d8bbf 
Signed-off-by: 11happy <[email protected]>
@11happy
Minor Fix
d4b3eba 
Signed-off-by: 11happy <[email protected]>
@11happy
Rebased
878c9b1 
Signed-off-by: 11happy <[email protected]>
@11happy
Rebase1
ad8f8e8 
Signed-off-by: 11happy <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@11happy
Copy link
Contributor Author

11happy commented Jan 6, 2024 •
edited
Loading

Hello @cor3ntin In my previous pull request I mistakenly added all the commits so I closed that one and opened this new one.Sorry for any inconvenience .

@11happy
Copy link
Contributor Author

11happy commented Jan 6, 2024

Hello @Endilll Can you please look into this and request for reviews and review this. I am sorry for my mistake.

cor3ntin
cor3ntin reviewed Jan 6, 2024
View reviewed changes
clang/docs/ReleaseNotes.rst Outdated
Comment on lines 873 to 875
- Fixed a bug where Template Instantiation failed to handle Lambda Expressions
with certain types of Attributes.
(`#76521 <https://github.com/llvm/llvm-project/issues/76521>`_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my previous mistake I think it got removed unintentionally ,sorry from my end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add that to a new commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected that.

@cor3ntin cor3ntin added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Jan 6, 2024
@cor3ntin
Copy link
Contributor

cor3ntin commented Jan 6, 2024

Review previously done in #76680

cor3ntin
cor3ntin approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Congratulation on your first contribution!

@11happy
Copy link
Contributor Author

11happy commented Jan 7, 2024

Thanks, I am really grateful for your guidance.

@11happy
Copy link
Contributor Author

11happy commented Jan 10, 2024

Are there any more changes for this PR required from my end?

@cor3ntin cor3ntin merged commit efcf192 into llvm:main Jan 10, 2024
@11happy 11happy deleted the FirstPR branch January 10, 2024 08:22
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
@11happy @justinfargnoli
Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (l…
0c77bcc 
…lvm#77194)

**Overview:**
Fix a bug where Clang's range-loop-analysis incorrectly checks for trivial copyability instead
of trivial copy constructibility, leading to erroneous warnings.

Fixes llvm#47355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor3ntin cor3ntin cor3ntin approved these changes

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

range-loop-analysis checks for trivial copyability, rather than trivial copy-constructibility
2 participants
@11happy @cor3ntin