-
Notifications
You must be signed in to change notification settings - Fork 14.1k
[libc++][doc] Marks LWG3257 as complete #77237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The macros were updated already updated - __cpp_lib_string_view in 466df17 - __cpp_lib_array_constexpr in 77b9abf Based on the dates of the commit and that P0858 "Constexpr iterator requirements" was completed in LLVM 12, set this issue as completed in the same version. Completes - LWG3257 Missing feature testing macro update from P0858
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesThe macros were updated already updated Based on the dates of the commit and that Completes
Full diff: https://github.com/llvm/llvm-project/pull/77237.diff 1 Files Affected:
diff --git a/libcxx/docs/Status/Cxx20Issues.csv b/libcxx/docs/Status/Cxx20Issues.csv
index e07db8d919dd58..964c21df97e215 100644
--- a/libcxx/docs/Status/Cxx20Issues.csv
+++ b/libcxx/docs/Status/Cxx20Issues.csv
@@ -176,7 +176,7 @@
"`3245 <https://wg21.link/LWG3245>`__","Unnecessary restriction on ``'%p'``\ parse specifier","Belfast","","","|chrono|"
"`3244 <https://wg21.link/LWG3244>`__","Constraints for ``Source``\ in |sect|\ [fs.path.req] insufficiently constrainty","Belfast","",""
"`3241 <https://wg21.link/LWG3241>`__","``chrono-spec``\ grammar ambiguity in |sect|\ [time.format]","Belfast","|Complete|","16.0","|chrono| |format|"
-"`3257 <https://wg21.link/LWG3257>`__","Missing feature testing macro update from P0858","Belfast","",""
+"`3257 <https://wg21.link/LWG3257>`__","Missing feature testing macro update from P0858","Belfast","|Complete|","12.0"
"`3256 <https://wg21.link/LWG3256>`__","Feature testing macro for ``constexpr``\ algorithms","Belfast","|Complete|","13.0"
"`3273 <https://wg21.link/LWG3273>`__","Specify ``weekday_indexed``\ to range of ``[0, 7]``\ ","Belfast","|Complete|","16.0","|chrono|"
"`3070 <https://wg21.link/LWG3070>`__","``path::lexically_relative``\ causes surprising results if a filename can also be a *root-name*","Belfast","",""
|
A bit off topic: llvm-project/libcxx/include/tuple Line 1421 in 752df2b
llvm-project/libcxx/include/tuple Line 1425 in 752df2b
|
Thanks I had a look and I think that issue is almost addressed, but a bit more "bookkeeping" needs to be done. I'll pick that up now. |
The macros were already updated - __cpp_lib_string_view in 466df17 - __cpp_lib_array_constexpr in 77b9abf Based on the dates of the commit and that P0858 "Constexpr iterator requirements" was completed in LLVM 12, set this issue as completed in the same version. Completes - LWG3257 Missing feature testing macro update from P0858
The macros were already updated
Based on the dates of the commit and that
P0858 "Constexpr iterator requirements"
was completed in LLVM 12, set this issue as completed in the same version.
Completes