Skip to content

[libc++][doc] Marks LWG3257 as complete #77237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

mordante
Copy link
Member

@mordante mordante commented Jan 7, 2024

The macros were already updated

  • __cpp_lib_string_view in 466df17
  • __cpp_lib_array_constexpr in 77b9abf

Based on the dates of the commit and that
P0858 "Constexpr iterator requirements"
was completed in LLVM 12, set this issue as completed in the same version.

Completes

  • LWG3257 Missing feature testing macro update from P0858

The macros were updated already updated
- __cpp_lib_string_view in 466df17
- __cpp_lib_array_constexpr in 77b9abf

Based on the dates of the commit and that
 P0858 "Constexpr iterator requirements"
was completed in LLVM 12, set this issue as completed in the same version.

Completes
- LWG3257 Missing feature testing macro update from P0858
@mordante mordante requested a review from a team as a code owner January 7, 2024 12:53
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 7, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 7, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

The macros were updated already updated

  • __cpp_lib_string_view in 466df17
  • __cpp_lib_array_constexpr in 77b9abf

Based on the dates of the commit and that
P0858 "Constexpr iterator requirements"
was completed in LLVM 12, set this issue as completed in the same version.

Completes

  • LWG3257 Missing feature testing macro update from P0858

Full diff: https://github.com/llvm/llvm-project/pull/77237.diff

1 Files Affected:

  • (modified) libcxx/docs/Status/Cxx20Issues.csv (+1-1)
diff --git a/libcxx/docs/Status/Cxx20Issues.csv b/libcxx/docs/Status/Cxx20Issues.csv
index e07db8d919dd58..964c21df97e215 100644
--- a/libcxx/docs/Status/Cxx20Issues.csv
+++ b/libcxx/docs/Status/Cxx20Issues.csv
@@ -176,7 +176,7 @@
 "`3245 <https://wg21.link/LWG3245>`__","Unnecessary restriction on ``'%p'``\  parse specifier","Belfast","","","|chrono|"
 "`3244 <https://wg21.link/LWG3244>`__","Constraints for ``Source``\  in |sect|\ [fs.path.req] insufficiently constrainty","Belfast","",""
 "`3241 <https://wg21.link/LWG3241>`__","``chrono-spec``\  grammar ambiguity in |sect|\ [time.format]","Belfast","|Complete|","16.0","|chrono| |format|"
-"`3257 <https://wg21.link/LWG3257>`__","Missing feature testing macro update from P0858","Belfast","",""
+"`3257 <https://wg21.link/LWG3257>`__","Missing feature testing macro update from P0858","Belfast","|Complete|","12.0"
 "`3256 <https://wg21.link/LWG3256>`__","Feature testing macro for ``constexpr``\  algorithms","Belfast","|Complete|","13.0"
 "`3273 <https://wg21.link/LWG3273>`__","Specify ``weekday_indexed``\  to range of ``[0, 7]``\ ","Belfast","|Complete|","16.0","|chrono|"
 "`3070 <https://wg21.link/LWG3070>`__","``path::lexically_relative``\  causes surprising results if a filename can also be a  *root-name*","Belfast","",""

@Zingam
Copy link
Contributor

Zingam commented Jan 7, 2024

A bit off topic:
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2517r1.html states that it is already implemented and IMO it looks like it was:

__apply_tuple_impl(_Fn&& __f, _Tuple&& __t, __tuple_indices<_Id...>)

inline _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) apply(_Fn&& __f, _Tuple&& __t) _LIBCPP_NOEXCEPT_RETURN(

@mordante
Copy link
Member Author

mordante commented Jan 7, 2024

A bit off topic: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2517r1.html states that it is already implemented and IMO it looks like it was:

__apply_tuple_impl(_Fn&& __f, _Tuple&& __t, __tuple_indices<_Id...>)

inline _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) apply(_Fn&& __f, _Tuple&& __t) _LIBCPP_NOEXCEPT_RETURN(

Thanks I had a look and I think that issue is almost addressed, but a bit more "bookkeeping" needs to be done. I'll pick that up now.

@mordante mordante merged commit 0141010 into llvm:main Jan 8, 2024
@mordante mordante deleted the LWG3257 branch January 8, 2024 16:25
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
The macros were already updated
- __cpp_lib_string_view in 466df17
- __cpp_lib_array_constexpr in 77b9abf

Based on the dates of the commit and that
 P0858 "Constexpr iterator requirements"
was completed in LLVM 12, set this issue as completed in the same
version.

Completes
- LWG3257 Missing feature testing macro update from P0858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants