[MLIR][Bufferizer][NFC] Simplify some codes. #77254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cleanup
|
@llvm/pr-subscribers-mlir-bufferization Author: Javed Absar (javedabsar1) ChangesNFC. clean up. Full diff: https://github.com/llvm/llvm-project/pull/77254.diff 2 Files Affected:
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp b/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
index 98a60a48763ab1..943d96b9d542ab 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
@@ -49,7 +49,7 @@ void BufferViewFlowAnalysis::rename(Value from, Value to) {
dependencies[to] = dependencies[from];
dependencies.erase(from);
- for (auto &[key, value] : dependencies) {
+ for (auto &[ _, value] : dependencies) {
if (value.contains(from)) {
value.insert(to);
value.erase(from);
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp b/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
index 4a418a05e6ff56..78b70114fabd12 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
@@ -53,10 +53,9 @@ neededValuesDominateInsertionPoint(const DominanceInfo &domInfo,
static bool insertionPointDominatesUses(const DominanceInfo &domInfo,
Operation *insertionPoint,
Operation *emptyTensorOp) {
- for (Operation *user : emptyTensorOp->getUsers())
- if (!domInfo.dominates(insertionPoint, user))
- return false;
- return true;
+ return llvm::all_of(
+ emptyTensorOp->getUsers(),
+ [&](Operation *user) { return domInfo.dominates(insertionPoint, user); });
}
/// Find a valid insertion point for a replacement of `emptyTensorOp`, assuming
|
|
@llvm/pr-subscribers-mlir Author: Javed Absar (javedabsar1) ChangesNFC. clean up. Full diff: https://github.com/llvm/llvm-project/pull/77254.diff 2 Files Affected:
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp b/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
index 98a60a48763ab1..943d96b9d542ab 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.cpp
@@ -49,7 +49,7 @@ void BufferViewFlowAnalysis::rename(Value from, Value to) {
dependencies[to] = dependencies[from];
dependencies.erase(from);
- for (auto &[key, value] : dependencies) {
+ for (auto &[ _, value] : dependencies) {
if (value.contains(from)) {
value.insert(to);
value.erase(from);
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp b/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
index 4a418a05e6ff56..78b70114fabd12 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp
@@ -53,10 +53,9 @@ neededValuesDominateInsertionPoint(const DominanceInfo &domInfo,
static bool insertionPointDominatesUses(const DominanceInfo &domInfo,
Operation *insertionPoint,
Operation *emptyTensorOp) {
- for (Operation *user : emptyTensorOp->getUsers())
- if (!domInfo.dominates(insertionPoint, user))
- return false;
- return true;
+ return llvm::all_of(
+ emptyTensorOp->getUsers(),
+ [&](Operation *user) { return domInfo.dominates(insertionPoint, user); });
}
/// Find a valid insertion point for a replacement of `emptyTensorOp`, assuming
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
matthias-springer
approved these changes
Jan 8, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
NFC. clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC. clean up.