[polly][ScheduleOptimizer] Reland Fix long compile time(hang) reported in polly #77280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SL quota There is no upper cap set on current Schedule Optimizer to compute schedule. In some cases a very long compile time taken to compute the schedule resulting in hang kind of behavior. This patch introduces a flag 'polly-schedule-computeout' to pass the cap which is initialized to 300000. This patch handles the compute out cases by bailing out and exiting gracefully. Change-Id: Id506832df4ae8d3f140579ba10cf570e18efac62
kartcq
added a commit
to kartcq/llvm-project
that referenced
this pull request
Jan 24, 2024
…f explicit restoration To fix long compile time issue of Schedule optimizer, patch llvm#77280 sets the upper cap on max ISL operations. In case of bailing out when isl quota is hit, error handling behavior was restored manually. This commit replaces the restoration code with IslMaxOperationsGuard helper and also removes redundant early return.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
…d in polly (llvm#77280) There is no upper cap set on current Schedule Optimizer to compute schedule. In some cases a very long compile time taken to compute the schedule resulting in hang kind of behavior. This patch introduces a flag 'polly-schedule-computeout' to pass the capwhich is initialized to 300000. This patch handles the compute out cases by bailing out and exiting gracefully. Fixed the test that failed in previous commit. Fixes llvm#69090
kartcq
added a commit
to kartcq/llvm-project
that referenced
this pull request
Jan 30, 2024
…f explicit restoration To fix long compile time issue of Schedule optimizer, patch llvm#77280 sets the upper cap on max ISL operations. In case of bailing out when isl quota is hit, error handling behavior was restored manually. This commit replaces the restoration code with IslMaxOperationsGuard helper and also removes redundant early return. This way of using helper is less error-prone as well.
efriedma-quic
pushed a commit
that referenced
this pull request
Feb 14, 2024
…f explicit restoration (#79303) To fix long compile time issue of Schedule optimizer, patch #77280 sets the upper cap on max ISL operations. In case of bailing out when ISL quota is hit, error handling behavior was restored manually. This commit replaces the restoration code with IslMaxOperationsGuard helper and also removes redundant early return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[polly][ScheduleOptimizer] There is no upper cap set on current Schedule Optimizer to compute schedule. In some cases a very long compile time taken to compute the schedule resulting in hang kind of behavior. This patch introduces a flag 'polly-schedule-computeout' to pass the cap which is initialized to 300000. This patch handles the compute out cases by bailing out and exiting gracefully.
This patch fixes the bug reported under polly : #69090
Fixed the test that failed in previous commit.