[PGO] Fix instrprof-api.c on Windows
#77508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-pgo Author: Qiongsi Wu (qiongsiwu) Changes#76471 introduced a new test but the check line has over-restrictive pattern for a string variable name that causes test failure on Windows (e.g. https://lab.llvm.org/buildbot/#/builders/127/builds/60637/steps/4/logs/stdio). This PR fixes the test. Full diff: https://github.com/llvm/llvm-project/pull/77508.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/instrprof-api.c b/compiler-rt/test/profile/instrprof-api.c
index 1381300c1ad18a..b6f75426b2a717 100644
--- a/compiler-rt/test/profile/instrprof-api.c
+++ b/compiler-rt/test/profile/instrprof-api.c
@@ -29,8 +29,8 @@ int foo() {
int main() {
int z = foo() + 3;
__llvm_profile_set_filename("rawprof.profraw");
- // PROFGEN: call void @__llvm_profile_set_filename(ptr noundef @.str)
- // PROFUSE-NOT: call void @__llvm_profile_set_filename(ptr noundef @.str)
+ // PROFGEN: call void @__llvm_profile_set_filename(ptr noundef @{{.*}})
+ // PROFUSE-NOT: call void @__llvm_profile_set_filename(ptr noundef @{{.*}})
if (__llvm_profile_dump())
return 2;
// PROFGEN: %call1 = call {{(signext )*}}i32 @__llvm_profile_dump()
|
mingmingl-llvm
approved these changes
Jan 9, 2024
MaskRay
approved these changes
Jan 9, 2024
|
The precommit CI is waiting for a long time. I tested this PR locally and it looks good. I am landing the PR. |
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
llvm#76471 introduced a new test but the check lines have over-restrictive patterns for a string variable name that cause test failures on Windows (e.g. https://lab.llvm.org/buildbot/#/builders/127/builds/60637/steps/4/logs/stdio). This PR fixes the test.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Issue llvm#77546 This reverts commit b6d1577.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76471 introduced a new test but the check lines have over-restrictive patterns for a string variable name that cause test failures on Windows (e.g. https://lab.llvm.org/buildbot/#/builders/127/builds/60637/steps/4/logs/stdio). This PR fixes the test.