[lldb][Progress] Separate title and details #77547

chelcassanova · 2024-01-10T02:38:03Z

Per this RFC:
https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. Also updates the test to check for details being correctly reported from the event structured data dictionary.

Per this RFC: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. Also updates the test to check for details being correctly reported from the event structured data dictionary.

llvmbot · 2024-01-10T02:38:32Z

@llvm/pr-subscribers-lldb

Author: Chelsea Cassanova (chelcassanova)

Changes

Per this RFC:
https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. Also updates the test to check for details being correctly reported from the event structured data dictionary.

Full diff: https://github.com/llvm/llvm-project/pull/77547.diff

8 Files Affected:

(modified) lldb/include/lldb/Core/DebuggerEvents.h (+2-2)
(modified) lldb/include/lldb/Core/Progress.h (+2-1)
(modified) lldb/source/Core/Progress.cpp (+4-3)
(modified) lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (+1-1)
(modified) lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp (+1-3)
(modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (+2-4)
(modified) lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp (+1-3)
(modified) lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py (+2)

diff --git a/lldb/include/lldb/Core/DebuggerEvents.h b/lldb/include/lldb/Core/DebuggerEvents.h
index 982b22229701f8..1fadb96a4b565d 100644
--- a/lldb/include/lldb/Core/DebuggerEvents.h
+++ b/lldb/include/lldb/Core/DebuggerEvents.h
@@ -20,9 +20,9 @@ class Stream;
 
 class ProgressEventData : public EventData {
 public:
-  ProgressEventData(uint64_t progress_id, std::string title, std::string update,
+  ProgressEventData(uint64_t progress_id, std::string title, std::string details,
                     uint64_t completed, uint64_t total, bool debugger_specific)
-      : m_title(std::move(title)), m_details(std::move(update)),
+      : m_title(std::move(title)), m_details(std::move(details)),
         m_id(progress_id), m_completed(completed), m_total(total),
         m_debugger_specific(debugger_specific) {}
 
diff --git a/lldb/include/lldb/Core/Progress.h b/lldb/include/lldb/Core/Progress.h
index b2b8781a43b059..1ea6df01a4bd4a 100644
--- a/lldb/include/lldb/Core/Progress.h
+++ b/lldb/include/lldb/Core/Progress.h
@@ -69,7 +69,7 @@ class Progress {
   ///
   /// @param [in] debugger An optional debugger pointer to specify that this
   /// progress is to be reported only to specific debuggers.
-  Progress(std::string title, uint64_t total = UINT64_MAX,
+    Progress(std::string title, std::string details = {}, uint64_t total = UINT64_MAX,
            lldb_private::Debugger *debugger = nullptr);
 
   /// Destroy the progress object.
@@ -96,6 +96,7 @@ class Progress {
   static std::atomic<uint64_t> g_id;
   /// The title of the progress activity.
   std::string m_title;
+  std::string m_details;
   std::mutex m_mutex;
   /// A unique integer identifier for progress reporting.
   const uint64_t m_id;
diff --git a/lldb/source/Core/Progress.cpp b/lldb/source/Core/Progress.cpp
index ea3f874916a999..8c99b561373362 100644
--- a/lldb/source/Core/Progress.cpp
+++ b/lldb/source/Core/Progress.cpp
@@ -16,9 +16,9 @@ using namespace lldb_private;
 
 std::atomic<uint64_t> Progress::g_id(0);
 
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, std::string details, uint64_t total,
                    lldb_private::Debugger *debugger)
-    : m_title(title), m_id(++g_id), m_completed(0), m_total(total) {
+    : m_title(title), m_details(details), m_id(++g_id), m_completed(0), m_total(total) {
   assert(total > 0);
   if (debugger)
     m_debugger_id = debugger->GetID();
@@ -38,6 +38,7 @@ Progress::~Progress() {
 void Progress::Increment(uint64_t amount, std::string update) {
   if (amount > 0) {
     std::lock_guard<std::mutex> guard(m_mutex);
+    m_details = update;
     // Watch out for unsigned overflow and make sure we don't increment too
     // much and exceed m_total.
     if (amount > (m_total - m_completed))
@@ -53,7 +54,7 @@ void Progress::ReportProgress(std::string update) {
     // Make sure we only send one notification that indicates the progress is
     // complete.
     m_complete = m_completed == m_total;
-    Debugger::ReportProgress(m_id, m_title, std::move(update), m_completed,
+    Debugger::ReportProgress(m_id, m_title, m_details, m_completed,
                              m_total, m_debugger_id);
   }
 }
diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 182a9f2afaeb2e..f451bac598b874 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -2225,7 +2225,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
   const char *file_name = file.GetFilename().AsCString("<Unknown>");
   LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
   LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
-  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name));
+  Progress progress("Parsing symbol table", file_name);
 
   llvm::MachO::symtab_command symtab_load_command = {0, 0, 0, 0, 0, 0};
   llvm::MachO::linkedit_data_command function_starts_load_command = {0, 0, 0, 0};
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp b/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
index 16ff5f7d4842ca..52555908865b0b 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
@@ -75,9 +75,7 @@ void ManualDWARFIndex::Index() {
   // Include 2 passes per unit to index for extracting DIEs from the unit and
   // indexing the unit, and then 8 extra entries for finalizing each index set.
   const uint64_t total_progress = units_to_index.size() * 2 + 8;
-  Progress progress(
-      llvm::formatv("Manually indexing DWARF for {0}", module_desc.GetData()),
-      total_progress);
+  Progress progress("Manually indexing DWARF", module_desc.GetData(), total_progress);
 
   std::vector<IndexSet> sets(units_to_index.size());
 
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index 1a16b70f42fe1f..1ea14366ad7dd7 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -519,8 +519,7 @@ void SymbolFileDWARF::InitializeObject() {
 
     if (apple_names.GetByteSize() > 0 || apple_namespaces.GetByteSize() > 0 ||
         apple_types.GetByteSize() > 0 || apple_objc.GetByteSize() > 0) {
-      Progress progress(llvm::formatv("Loading Apple DWARF index for {0}",
-                                      module_desc.GetData()));
+      Progress progress("Loading Apple DWARF index", module_desc.GetData());
       m_index = AppleDWARFIndex::Create(
           *GetObjectFile()->GetModule(), apple_names, apple_namespaces,
           apple_types, apple_objc, m_context.getOrLoadStrData());
@@ -532,8 +531,7 @@ void SymbolFileDWARF::InitializeObject() {
     DWARFDataExtractor debug_names;
     LoadSectionData(eSectionTypeDWARFDebugNames, debug_names);
     if (debug_names.GetByteSize() > 0) {
-      Progress progress(
-          llvm::formatv("Loading DWARF5 index for {0}", module_desc.GetData()));
+      Progress progress("Loading DWARF5 index", module_desc.GetData());
       llvm::Expected<std::unique_ptr<DebugNamesDWARFIndex>> index_or =
           DebugNamesDWARFIndex::Create(*GetObjectFile()->GetModule(),
                                        debug_names,
diff --git a/lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp b/lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp
index ed014f99fdb5e7..52ae7adb8d3d97 100644
--- a/lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp
+++ b/lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp
@@ -98,9 +98,7 @@ std::optional<FileSpec> SymbolLocatorDefault::LocateExecutableSymbolFile(
       FileSystem::Instance().Exists(symbol_file_spec))
     return symbol_file_spec;
 
-  Progress progress(llvm::formatv(
-      "Locating external symbol file for {0}",
-      module_spec.GetFileSpec().GetFilename().AsCString("<Unknown>")));
+  Progress progress("Locating external symbol file", module_spec.GetFileSpec().GetFilename().AsCString("<Unknown>"));
 
   FileSpecList debug_file_search_paths = default_search_paths;
 
diff --git a/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py b/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py
index 0e72770e350366..9af53845ca1b77 100644
--- a/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py
+++ b/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py
@@ -39,3 +39,5 @@ def test_dwarf_symbol_loading_progress_report_structured_data(self):
         progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
         message = progress_data.GetValueForKey("message").GetStringValue(100)
         self.assertGreater(len(message), 0)
+        details = progress_data.GetValueForKey("details").GetStringValue(100)
+        self.assertGreater(len(details), 0)

github-actions · 2024-01-10T02:40:29Z

✅ With the latest revision this PR passed the C/C++ code formatter.

Formatting

clayborg

The roots of this look really good. A few nits we can choose to fix or do in another patch.

clayborg · 2024-01-10T07:51:13Z

lldb/include/lldb/Core/Progress.h

@@ -69,7 +69,8 @@ class Progress {
  ///
  /// @param [in] debugger An optional debugger pointer to specify that this
  /// progress is to be reported only to specific debuggers.
-  Progress(std::string title, uint64_t total = UINT64_MAX,
+  Progress(std::string title, std::string details = {},
+           uint64_t total = UINT64_MAX,


Might be good to start using std::optional<uint64_t> internally in the Progress class and avoid the magic numbers as long as we are changing things up

For sure, this was actually a part of the original patch I made trying to introduce the aggregate flag.

clayborg · 2024-01-10T07:52:57Z

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

@@ -519,8 +519,7 @@ void SymbolFileDWARF::InitializeObject() {

    if (apple_names.GetByteSize() > 0 || apple_namespaces.GetByteSize() > 0 ||
        apple_types.GetByteSize() > 0 || apple_objc.GetByteSize() > 0) {
-      Progress progress(llvm::formatv("Loading Apple DWARF index for {0}",
-                                      module_desc.GetData()));
+      Progress progress("Loading Apple DWARF index", module_desc.GetData());


Should we get rid of this? This will never take any time to load and will just cause progress spam. I would vote to remove this unless there is something that can take time, but I can't think of anything.

This can be removed, I also have to update the progress report for ELF files to match the rest of the changes here 😅

clayborg · 2024-01-10T07:54:21Z

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

@@ -532,8 +531,7 @@ void SymbolFileDWARF::InitializeObject() {
    DWARFDataExtractor debug_names;
    LoadSectionData(eSectionTypeDWARFDebugNames, debug_names);
    if (debug_names.GetByteSize() > 0) {
-      Progress progress(
-          llvm::formatv("Loading DWARF5 index for {0}", module_desc.GetData()));
+      Progress progress("Loading DWARF5 index", module_desc.GetData());


DWARF5 on the other hand usually has a single .debug_names table per compile unit, and there can be mixed DWARF5 .debug_names tables along with some compile units that need to be manually indexed, so it might be worth keeping this progress.

Updates the ELF index progress report, remove the Apple DWARF progress report and use a std::optional for the `m_total` field in `Progress`

clayborg

A bit more cleanup, see inline comment

clayborg · 2024-01-10T20:38:19Z

lldb/source/Core/Progress.cpp

  ReportProgress();
 }

 void Progress::Increment(uint64_t amount, std::string update) {
  if (amount > 0) {
    std::lock_guard<std::mutex> guard(m_mutex);
+    m_details = update;


We should probably make std::string update into std::optional<std::string> updated_detail as we default this argument to an empty string currently and the first call to this function from the DWARF indexer will then clear the DWARF path since update will be empty. Now that m_details is the only thing that holds onto the filename for all progresses, we don't want the Increment(...) call to result the m_details. This code will now need to be:

if (updated_detail) m_details = *updated_detail;

Good point, I'll add the std::optional for Increment and remove this parameter from ReportProgress 👍🏾

clayborg · 2024-01-10T20:44:17Z

lldb/source/Core/Progress.cpp

-    if (amount > (m_total - m_completed))
-      m_completed = m_total;
+    if (m_total.has_value() && (amount > (m_total.value() - m_completed)))
+      m_completed = m_total.value();
    else
      m_completed += amount;
    ReportProgress(update);


We are now storing any new detail into m_details, do we need to send this to ReportProgress now? Prior to this, this string wasn't stored anywhere but now we have a copy, so we should probably remove the parameter to this.

clayborg · 2024-01-10T20:44:54Z

lldb/source/Core/Progress.cpp

@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) {
 void Progress::ReportProgress(std::string update) {


remove std::string update as we have it in m_details

clayborg · 2024-01-10T21:03:39Z

lldb/source/Core/Progress.cpp

+    Debugger::ReportProgress(m_id, m_title, m_details, m_completed,
+                             m_total.value_or(0), m_debugger_id);


This will actually mess up reporting of progress reports with no valid total. We will always sent out completed = 0 and total = 0 for both the start and end events. The easiest way to fix this would be to leave m_total as a uint64_t inside of progress, but still allow the argument to be an optional in the constructor. We need completed to not be equal to total, the start progress event will have completed=0 and total=<non-zero>, and then the end event will need to have completed=total where total is non zero.

Not sure how I didn't realize that, I had this implementation from my first patch for a bool flag for this. Weirdly enough the test passed with those changes even though I don't think they should've. Either way I'll update this, my mistake.

clayborg · 2024-01-10T21:05:39Z

lldb/include/lldb/Core/Progress.h

-  /// Total amount of work, UINT64_MAX for non deterministic progress.
-  const uint64_t m_total;
+  /// Total amount of work, use a std::nullopt for non deterministic progress.
+  const std::optional<uint64_t> m_total;


We need to leave this as a uint64_t so that we can report progress start events and end events correctly. See comments in Progress::ReportProgress(...). We need total to be reported as non-zero as the end events are considered a notification where completed == total

clayborg · 2024-01-10T21:07:19Z

lldb/source/Core/Progress.cpp

+    : m_title(title), m_details(details), m_id(++g_id), m_completed(0),
+      m_total(total) {
+  assert(total == std::nullopt || total > 0);


We need total to be non zero when there is no actual total:

m_total(1) { // Default to one if in case there is no valid total // Set the actual total if we have a valid value if (total) m_total = *total;

clayborg · 2024-01-10T21:08:20Z

lldb/source/Core/Progress.cpp

+  if (m_total.has_value() && !m_completed)
+    m_completed = m_total.value();


revert (see comments above and down in Progress::ReportProgress(...) for details

Seconded from your comments on ReportProgress above.

variable for total Change the parameter for `Increment` to use a std::optional string for the updated details as well as remove the string parameter for `ReportProgress` as its no longer necessary since all details are being stored in a member variable at object creation. Also reverts Progress's `m_total` to being a uint64_t instead of having both the member variable and construction parameter both be a std::optional<uint64_t>

chelcassanova · 2024-01-10T22:45:05Z

lldb/include/lldb/Core/Progress.h

@@ -90,10 +90,11 @@ class Progress {
  /// @param [in] amount The amount to increment m_completed by.
  ///
  /// @param [in] an optional message associated with this update.
-  void Increment(uint64_t amount = 1, std::string update = {});
+  void Increment(uint64_t amount = 1,
+                 std::optional<std::string> updated_detail = {});


updated_detail is still kept as an empty string by default, though I'm unsure if the empty string or std::nullopt is preferred here

clayborg · 2024-01-11T00:50:00Z

lldb/source/Core/Progress.cpp

  if (amount > 0) {
    std::lock_guard<std::mutex> guard(m_mutex);
+    if (updated_detail)
+      m_details = *updated_detail;


We could use std::move() here to avoid a copy?

clayborg · 2024-01-11T00:50:41Z

lldb/source/Core/Progress.cpp

+    if (m_total)
+      m_complete = m_completed == m_total;


No need for the if statement anymore, these two lines can just be:

m_complete = m_completed == m_total;

When `m_details` is updated with `Increment` use std::move instead of making a copy of the updated details. Also removes the if clause that updates m_complete in `ReportProgress`

clayborg

Thanks for the changes. On comment might be able to be reverted, but this looks good.

clayborg · 2024-01-12T21:01:53Z

lldb/source/Core/Progress.cpp

  if (!m_complete) {
    // Make sure we only send one notification that indicates the progress is
-    // complete.
+    // complete, and only modify m_complete is m_total isn't null.


Is the comment out of date? revert comment?

Fix outdated comment

medismailben

LGTM!

Per this RFC: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. In addition, changes the total amount of progress completed into a std::optional. Also updates the test to check for details being correctly reported from the event structured data dictionary. Some changes were made to Swift progress reports to match the upstream changes to `Progress`. (cherry picked from commit f1ef910)

Per this RFC: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. In addition, changes the total amount of progress completed into a std::optional. Also updates the test to check for details being correctly reported from the event structured data dictionary.

The `total` parameter for the constructor for Progress was changed to a std::optional in llvm#77547. When initializing the `m_total` member variable for progress, it is set to 1 if the `total` parameter is std::nullopt. Other areas of the code were still checking if `m_total` was a UINT64_MAX to determine if the progress was deterministic or not, so these have been changed to check for the integer 1. The member variable `m_total` could be changed to a std::optional as well, but this means that the `ProgressEventData::GetTotal()` (which is used for the public API) would either need to return a std::optional value or it would return some specific integer to represent non-deterministic progress if `m_total` is std::nullopt.

…9912) The `total` parameter for the constructor for Progress was changed to a std::optional in #77547. It was originally set to 1 to indicate non-determinisitic progress, but this commit changes this. First, `UINT64_MAX` will again be used for non-deterministic progress, and `Progress` now has a static variable set to this value so that we can use this instead of a magic number. The member variable `m_total` could be changed to a std::optional as well, but this means that the `ProgressEventData::GetTotal()` (which is used for the public API) would either need to return a std::optional value or it would return some specific integer to represent non-deterministic progress if `m_total` is std::nullopt.

Per this RFC: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on improving progress reports, this commit separates the title field and details field so that the title specifies the category that the progress report falls under. The details field is added as a part of the constructor for progress reports and by default is an empty string. In addition, changes the total amount of progress completed into a std::optional. Also updates the test to check for details being correctly reported from the event structured data dictionary. Some changes were made to Swift progress reports to match the upstream changes to `Progress`. (cherry picked from commit f1ef910) (cherry picked from commit 342d11d)

[lldb][Progress] Separate title and details (llvm#77547) (#7978)

…vm#79912) The `total` parameter for the constructor for Progress was changed to a std::optional in llvm#77547. It was originally set to 1 to indicate non-determinisitic progress, but this commit changes this. First, `UINT64_MAX` will again be used for non-deterministic progress, and `Progress` now has a static variable set to this value so that we can use this instead of a magic number. The member variable `m_total` could be changed to a std::optional as well, but this means that the `ProgressEventData::GetTotal()` (which is used for the public API) would either need to return a std::optional value or it would return some specific integer to represent non-deterministic progress if `m_total` is std::nullopt. (cherry picked from commit 733b86d)

As part of the effort to improve progress reporting in LLDB (https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we want a way to keep track of progress reports to see if they're ongoing. The ultimate goal is to use this information to essentially keep these reports alive using timeouts to more gracefully deliver these reports. To lay the groundwork to do this, this commit adds a map to progress reports that keeps track of each category of reports (using the changes from llvm#77547) and uses a refcount to check if these reports are still considered active or not. A refcount of at least one indicates that the report is still active. I've added an enum to `Progress.h` to toggle whether this behaviour is used or not. By default it is not used, so this commit is marked as NFC.

chelcassanova requested review from JDevlieghere, clayborg and medismailben January 10, 2024 02:38

llvmbot added the lldb label Jan 10, 2024

fixup! [lldb][Progress] Separate title and details

75de25c

Formatting

clayborg approved these changes Jan 10, 2024

View reviewed changes

Update ELF progress report, remove Apple DWARF report, use std::optional

8d7c2bf

Updates the ELF index progress report, remove the Apple DWARF progress report and use a std::optional for the `m_total` field in `Progress`

clayborg reviewed Jan 10, 2024

View reviewed changes

clayborg requested changes Jan 10, 2024

View reviewed changes

chelcassanova commented Jan 10, 2024

View reviewed changes

clayborg reviewed Jan 11, 2024

View reviewed changes

Use std::move when updating m_details

16996a8

When `m_details` is updated with `Increment` use std::move instead of making a copy of the updated details. Also removes the if clause that updates m_complete in `ReportProgress`

clayborg approved these changes Jan 12, 2024

View reviewed changes

Fix comment

3c2b8f7

Fix outdated comment

clayborg approved these changes Jan 15, 2024

View reviewed changes

medismailben approved these changes Jan 16, 2024

View reviewed changes

chelcassanova merged commit f1ef910 into llvm:main Jan 16, 2024

chelcassanova mentioned this pull request Jan 29, 2024

[lldb][progress] Correctly check total for deterministic progress #79912

Merged

JDevlieghere added a commit to swiftlang/llvm-project that referenced this pull request Feb 1, 2024

Merge pull request #8097 from chelcassanova/progress-report-cherrypick

e6c1e69

[lldb][Progress] Separate title and details (llvm#77547) (#7978)

chelcassanova mentioned this pull request Feb 7, 2024

[lldb][progress][NFC] Add groundwork to keep track of progress reports #81026

Closed

		@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) {
		void Progress::ReportProgress(std::string update) {

		Debugger::ReportProgress(m_id, m_title, m_details, m_completed,
		m_total.value_or(0), m_debugger_id);

		if (m_total.has_value() && !m_completed)
		m_completed = m_total.value();

[lldb][Progress] Separate title and details #77547

[lldb][Progress] Separate title and details #77547

Uh oh!

Conversation

chelcassanova commented Jan 10, 2024

Uh oh!

llvmbot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clayborg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clayborg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clayborg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

medismailben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 10, 2024 •

edited

Loading