Skip to content

[NFC][OpenMP][Flang] Add smoke test for omp target parallel #77579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DominikAdamski
Copy link
Contributor

Added test which proves that end-to-end compilation of omp target parallel costruct is successful for Flang compiler.

Added test which proves that end-to-end compilation of omp target
parallel costruct is successful for Flang compiler.
Comment on lines +2 to +7
! REQUIRES: flang
! UNSUPPORTED: nvptx64-nvidia-cuda-LTO
! UNSUPPORTED: aarch64-unknown-linux-gnu
! UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
! UNSUPPORTED: x86_64-pc-linux-gnu
! UNSUPPORTED: x86_64-pc-linux-gnu-LTO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we replace this with:

! REQUIRES: flang, amdgcn-amd-amdhsa

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we specify requirements as follows: REQUIRES: flang, amdgcn-amd-amdhsa then we will launch this test only for flang and AMDGPU (source: https://llvm.org/docs/TestingGuide.html ) . If we skip amdgcn-amd-amdhsa requirement, then we can launch the test with Flang + nvptx64-nvidia-cuda.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we specify requirements as follows: REQUIRES: flang, amdgcn-amd-amdhsa then we will launch this test only for flang and AMDGPU (source: https://llvm.org/docs/TestingGuide.html ) . If we skip amdgcn-amd-amdhsa requirement, then we can launch the test with Flang + nvptx64-nvidia-cuda.

Ah, my bad! I didn't notice the LTO part in nvptx64-nvidia-cuda-LTO!

@DominikAdamski DominikAdamski merged commit ee43128 into llvm:main Jan 11, 2024
@DominikAdamski DominikAdamski deleted the flang_omp_target_parallel_test branch January 11, 2024 09:18
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
Added test which proves that end-to-end compilation of omp target
parallel costruct is successful for Flang compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants