Skip to content

[clang][NFC] Improve comments in C++ DR test suite #77670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Endilll
Copy link
Contributor

@Endilll Endilll commented Jan 10, 2024

Previously, we've been mentioning tests that were placed in their own files in corresponding drNNxx.cpp file. This patch makes sure we do this consistently, and improves upon existing practice by specifying the name of the file test is placed in.

Previously, we've been mentioning tests that were placed in their own files in corresponding `drNNxx.cpp` file. This patch makes sure we do this consistently, and improves upon existing practice by specifying the name of the file test is placed in.
@Endilll
Copy link
Contributor Author

Endilll commented Jan 10, 2024

This PR is created to check it against CI

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jan 10, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 10, 2024

@llvm/pr-subscribers-clang

Author: Vlad Serebrennikov (Endilll)

Changes

Previously, we've been mentioning tests that were placed in their own files in corresponding drNNxx.cpp file. This patch makes sure we do this consistently, and improves upon existing practice by specifying the name of the file test is placed in.


Full diff: https://github.com/llvm/llvm-project/pull/77670.diff

4 Files Affected:

  • (modified) clang/test/CXX/drs/dr17xx.cpp (+6)
  • (modified) clang/test/CXX/drs/dr1xx.cpp (+2-2)
  • (modified) clang/test/CXX/drs/dr23xx.cpp (+2)
  • (modified) clang/test/CXX/drs/dr4xx.cpp (+1-1)
diff --git a/clang/test/CXX/drs/dr17xx.cpp b/clang/test/CXX/drs/dr17xx.cpp
index 0c44fb231ce51a..885ed00ace0f57 100644
--- a/clang/test/CXX/drs/dr17xx.cpp
+++ b/clang/test/CXX/drs/dr17xx.cpp
@@ -89,6 +89,8 @@ S s(q); // #dr1736-s
 #endif
 }
 
+// dr1748 is in dr1748.cpp
+
 namespace dr1753 { // dr1753: 11
   typedef int T;
   struct A { typedef int T; };
@@ -159,6 +161,8 @@ namespace dr1762 { // dr1762: 14
 #endif
 }
 
+// dr1772 is in dr177x.cpp
+
 namespace dr1778 { // dr1778: 9
   // Superseded by P1286R2.
 #if __cplusplus >= 201103L
@@ -174,6 +178,8 @@ namespace dr1778 { // dr1778: 9
 #endif
 }
 
+// dr1779 is in dr177x.cpp
+
 namespace dr1794 { // dr1794: yes
                    // NB: dup 1710
 #if __cplusplus >= 201103L
diff --git a/clang/test/CXX/drs/dr1xx.cpp b/clang/test/CXX/drs/dr1xx.cpp
index 064ecace59067a..064b69411f0b5f 100644
--- a/clang/test/CXX/drs/dr1xx.cpp
+++ b/clang/test/CXX/drs/dr1xx.cpp
@@ -283,7 +283,7 @@ namespace dr116 { // dr116: yes
 }
 
 // dr117: na
-// dr118 is in its own file.
+// dr118 is in dr118.cpp
 // dr119: na
 // dr120: na
 
@@ -789,7 +789,7 @@ namespace dr155 { // dr155: dup 632
   // expected-warning@-1 {{braces around scalar initializer}}
 }
 
-// dr158 is in its own file.
+// dr158 is in dr158.cpp
 
 namespace dr159 { // dr159: 3.5
   namespace X { void f(); }
diff --git a/clang/test/CXX/drs/dr23xx.cpp b/clang/test/CXX/drs/dr23xx.cpp
index 9ced61d2aae30d..d2f4e7652ab568 100644
--- a/clang/test/CXX/drs/dr23xx.cpp
+++ b/clang/test/CXX/drs/dr23xx.cpp
@@ -213,6 +213,8 @@ namespace dr2387 { // dr2387: 9
 #endif
 }
 
+// dr2390 is in dr2390.cpp
+
 namespace dr2394 { // dr2394: 15
 
 struct A {};
diff --git a/clang/test/CXX/drs/dr4xx.cpp b/clang/test/CXX/drs/dr4xx.cpp
index fd5c842c108571..fa90764df9b03b 100644
--- a/clang/test/CXX/drs/dr4xx.cpp
+++ b/clang/test/CXX/drs/dr4xx.cpp
@@ -282,7 +282,7 @@ namespace dr410 { // dr410: no
   // expected-note@#dr410-z {{declared private here}}
 }
 
-// dr412 is in its own file.
+// dr412 is in dr412.cpp
 
 namespace dr413 { // dr413: yes
   struct S {

@Endilll Endilll merged commit e51fe95 into llvm:main Jan 10, 2024
@Endilll Endilll deleted the separate-tests branch January 10, 2024 22:12
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
Previously, we've been mentioning tests that were placed in their own files in corresponding `drNNxx.cpp` file. This patch makes sure we do this consistently, and improves upon existing practice by specifying the name of the file test is placed in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants