Skip to content

[mlir][mesh] fix ProcessMultiIndexOp building #77676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sogartar
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the mlir label Jan 10, 2024
@sogartar sogartar requested a review from antiagainst January 10, 2024 19:52
@llvmbot
Copy link
Member

llvmbot commented Jan 10, 2024

@llvm/pr-subscribers-mlir

Author: Boian Petkantchin (sogartar)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/77676.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Mesh/IR/MeshOps.cpp (+1-1)
diff --git a/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp b/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
index 9b110c462915e7..957b380efd516b 100644
--- a/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
+++ b/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
@@ -353,7 +353,7 @@ void ProcessMultiIndexOp::build(OpBuilder &odsBuilder, OperationState &odsState,
                                 ClusterOp mesh) {
   build(odsBuilder, odsState,
         SmallVector<Type>(mesh.getRank(), odsBuilder.getIndexType()),
-        mesh.getSymName(), MeshAxesAttr());
+        mesh.getSymName(), ArrayRef<MeshAxis>());
 }
 
 void ProcessMultiIndexOp::build(OpBuilder &odsBuilder, OperationState &odsState,

@antiagainst
Copy link
Member

Could you provide more details on the issue in the message? Maybe also add link to some failure bot runs there.

@sogartar sogartar merged commit 31fd6d1 into llvm:main Jan 11, 2024
@sogartar
Copy link
Contributor Author

Could you provide more details on the issue in the message? Maybe also add link to some failure bot runs there.

I added a better message in the merge commit.

justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
Insert default empty mesh axes array instead of null attribute without MLIR context, since the attribute is default-valued not just optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants