[NFC][OpenMP][Flang] Add test for OpenMP target parallel do #77776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikAdamski
requested review from
ergawy,
skatrak,
jsjodin,
kiranchandramohan,
agozillon,
dpalermo and
kiranktp
ergawy
reviewed
Jan 17, 2024
Comment on lines
+16
to
+21
| !$omp target parallel do map(from: x) | ||
| do i = 1, 100 | ||
| x(i) = i | ||
| end do | ||
| !$omp end target parallel do |
There was a problem hiding this comment.
Since, AFAIU, offloading can silently fallback to the host, should we, in our offloading tests, always verify that offloading did indeed succeed somehow? I did this previously by taking device IDs and comparing them to make sure they are different. However, I am not sure this is the best approach.
Or do we not need to verify that at all?
There was a problem hiding this comment.
Done. Instead of modifying the code I based on libomptarget runtime logs (similar test case: https://github.com/llvm/llvm-project/blob/main/openmp/libomptarget/test/offloading/ompx_bare.c )
Added test which proves that end-to-end compilation of omp target parallel do costruct is successful for Flang compiler.
DominikAdamski
force-pushed
the
flang_omp_target_parallel_do_test
branch
from
8c63cf0 to
37d42b2
Compare
ergawy
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test which proves that end-to-end compilation of
omp target parallel docostruct is successful for Flang compiler.