Skip to content

[CodeGen] Fix ponential memory leak in CodeGenPassBuilderTest #77864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[CodeGen] Fix ponential memory leak in CodeGenPassBuilderTest #77864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/unittests/CodeGen/CodeGenPassBuilderTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class DummyCodeGenPassBuilder

class CodeGenPassBuilderTest : public testing::Test {
public:
LLVMTargetMachine *TM;
std::unique_ptr<LLVMTargetMachine> TM;

static void SetUpTestCase() {
InitializeAllTargets();
Expand All @@ -69,8 +69,8 @@ class CodeGenPassBuilderTest : public testing::Test {
GTEST_SKIP();

TargetOptions Options;
TM = static_cast<LLVMTargetMachine *>(
TheTarget->createTargetMachine("", "", "", Options, std::nullopt));
TM = std::unique_ptr<LLVMTargetMachine>(static_cast<LLVMTargetMachine *>(
TheTarget->createTargetMachine("", "", "", Options, std::nullopt)));
if (!TM)
GTEST_SKIP();
}
Expand All @@ -85,7 +85,7 @@ TEST_F(CodeGenPassBuilderTest, basic) {
PassInstrumentationCallbacks PIC;
DummyCodeGenPassBuilder CGPB(*TM, getCGPassBuilderOption(), &PIC);
PipelineTuningOptions PTO;
PassBuilder PB(TM, PTO, std::nullopt, &PIC);
PassBuilder PB(TM.get(), PTO, std::nullopt, &PIC);

PB.registerModuleAnalyses(MAM);
PB.registerCGSCCAnalyses(CGAM);
Expand Down