[flang] Fix const cast issue in FreeMemory function call in execute_command_line

[yiwu0b11]

The FreeMemory function only accepts a void pointer, but it was being called with a const char pointer, resulting in a type-casting issue.
To address this, the const was removed, use char * instead.

[llvmbot]

@llvm/pr-subscribers-flang-runtime

Author: Yi Wu (yi-wu-arm)

Changes

The FreeMemory function only accepts a void pointer, but it was being called with a const char pointer, resulting in a type-casting issue.
To address this, the commit replaces the direct cast with a const_cast<void *>(static_cast<const void *>(newCmd).

---

Full diff: https://github.com/llvm/llvm-project/pull/77906.diff

1 Files Affected:

• (modified) flang/runtime/execute.cpp (+1-1)

diff --git a/flang/runtime/execute.cpp b/flang/runtime/execute.cpp
index 48773ae8114b0b..fa2b7eca0dde69 100644
--- a/flang/runtime/execute.cpp
+++ b/flang/runtime/execute.cpp
@@ -199,7 +199,7 @@ void RTNAME(ExecuteCommandLine)(const Descriptor &command, bool wait,
   }
   // Deallocate memory if EnsureNullTerminated dynamically allocated memory
   if (newCmd != command.OffsetElement()) {
-    FreeMemory((void *)newCmd);
+    FreeMemory(const_cast<void *>(static_cast<const void *>(newCmd)));
   }
 }
 

[yiwu0b11]

@klausler point it out in the flang slack channel:
flang/runtime/execute.cpp:202:24: error: cast from type 'const char*' to type 'void*' casts away qualifiers [-Werror=cast-qual]
202 | FreeMemory((void *)newCmd);
| ^~~~~~

[yiwu0b11]

Build and pass all test on clang 10.0.0 and on gcc 9.4.0