[clang] SyntaxWarning: invalid escape sequence '\s' with Python3.12 #78036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-project/clang/tools/libclang/linker-script-to-export-list.py:9: SyntaxWarning: invalid escape sequence '\s'
m = re.search("^\s+(clang_[^;]+)", line)
|
@llvm/pr-subscribers-clang Author: Jie Fu (傅杰) (DamonFool) ChangesThe following SyntaxWarning was observed with Python3.12 . Similar problem had been reported here https://stackoverflow.com/questions/57645829/why-am-i-getting-a-syntaxwarning-invalid-escape-sequence-s-warning . It would be better to fix it. Full diff: https://github.com/llvm/llvm-project/pull/78036.diff 1 Files Affected:
diff --git a/clang/tools/libclang/linker-script-to-export-list.py b/clang/tools/libclang/linker-script-to-export-list.py
index 745996028d835f..35bfa230be704a 100644
--- a/clang/tools/libclang/linker-script-to-export-list.py
+++ b/clang/tools/libclang/linker-script-to-export-list.py
@@ -6,6 +6,6 @@
output_file = open(sys.argv[2], "w")
for line in input_file:
- m = re.search("^\s+(clang_[^;]+)", line)
+ m = re.search("^\\s+(clang_[^;]+)", line)
if m:
output_file.write(m.group(1) + "\n")
|
cor3ntin
reviewed
Jan 13, 2024
Co-authored-by: cor3ntin <[email protected]>
MaskRay
approved these changes
Jan 14, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
…lvm#78036) llvm-project/clang/tools/libclang/linker-script-to-export-list.py:9: SyntaxWarning: invalid escape sequence '\s' m = re.search("^\s+(clang_[^;]+)", line) Co-authored-by: cor3ntin <[email protected]>
lukel97
added a commit
to lukel97/llvm-project
that referenced
this pull request
Feb 20, 2024
On Python 3.12 we now get a warning in common.py: llvm/utils/UpdateTestChecks/common.py:488: SyntaxWarning: invalid escape sequence '\s' This fixes it by using a raw string literal, see llvm#78036 and https://docs.python.org/3/library/re.html
lukel97
added a commit
that referenced
this pull request
Feb 20, 2024
On Python 3.12 we now get a warning in common.py: llvm/utils/UpdateTestChecks/common.py:488: SyntaxWarning: invalid escape sequence '\s' This fixes it by using a raw string literal, see #78036 and https://docs.python.org/3/library/re.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following SyntaxWarning was observed with Python3.12 .
Similar problem had been reported here https://stackoverflow.com/questions/57645829/why-am-i-getting-a-syntaxwarning-invalid-escape-sequence-s-warning .
It would be better to fix it.
Thanks.